Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for React Native new architecture and bridgeless #13116

Open
2 tasks
brentvatne opened this issue Mar 13, 2024 · 4 comments
Open
2 tasks

Support for React Native new architecture and bridgeless #13116

brentvatne opened this issue Mar 13, 2024 · 4 comments
Assignees
Labels
amazon-cognito-identity-js Used for issues related to this specific package within the monorepo feature-request Request a new feature React Native React Native related issue

Comments

@brentvatne
Copy link

Is this related to a new or existing framework?

React Native

Is this related to a new or existing API?

Authentication

Is this related to another service?

Cognito

Describe the feature you'd like to request

Hi there! I'm working on supporting the roll out of the new architecture + bridgeless with Expo and Meta, and as part of that we identified which libraries are depended on by the largest apps and the most popular native libraries on EAS Build to help prioritize which libraries to investigate. amazon-cognito-identity-js came up on that list. See the list on Google Sheets (request edit access if you'd like to update the status of amazon-cognito-identity-js after testing, or if you prefer to report back here on this issue it's fine too).

We want to start recommending folks try out the new architecture in the next release, react-native 0.74 / Expo SDK 51. Ideally we can get the ecosystem ready to switch over to the new architecture within the next few releases. So, we'll have from now until 0.74 release (before May) to give Meta feedback on anything that might not be working as expected with the new arch/bridgeless enabled.

Folks at Meta would really appreciate it if you could test your libraries against the latest release and report any issues that you find. This new version enables an interop layer by default, so hopefully many things will just work, but the more off of the beaten path of a simple module / view that a library goes the more likely it is to encounter possible issues ;) The following gist includes a step by step process for how to test your library and report issues: https://gist.github.com/cipolleschi/82b7a9561b8861330efabbd3eb08c6f5.

Describe the solution you'd like

amazon-cognito-identity-js is compatible with React Native's new architecture and bridgeless, and also compatible with the old architecture.

Describe alternatives you've considered

No alternatives that I'm aware of

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@brentvatne brentvatne added the pending-triage Issue is pending triage label Mar 13, 2024
@cshfang
Copy link
Contributor

cshfang commented Mar 13, 2024

@brentvatne - thanks for bringing this up. I have a couple of a clarifying questions:

  1. Is the ask to validate that amazon-cognito-identity-js works as-is with RN 0.74? I.e. there is not an ask here to update the package itself and
  2. Is this at all related to Expo Go?

@brentvatne
Copy link
Author

brentvatne commented Mar 14, 2024

hi @cshfang! thanks for the quick response.

  1. Is the ask to validate that amazon-cognito-identity-js works as-is with RN 0.74? I.e. there is not an ask here to update the package itself

correct! specifically, that it works with the latest react-native@0.74-rc with the new architecture, with bridgeless enabled and without it enabled, using the information in this doc as guidance: https://gist.github.com/cipolleschi/82b7a9561b8861330efabbd3eb08c6f5

I expect that it will just work because 0.74-rc enables an interop layer by default for new arch, and this module is fairly simple, but it would be good to verify!

  1. Is this at all related to Expo Go?

nope!

@cshfang
Copy link
Contributor

cshfang commented Mar 14, 2024

Gotcha. Will follow up with the team tomorrow morning and figure out a test plan.

Thanks!

@nadetastic nadetastic added amazon-cognito-identity-js Used for issues related to this specific package within the monorepo investigating This issue is being investigated labels Mar 14, 2024
@cwomack cwomack self-assigned this Mar 14, 2024
@cwomack cwomack added the React Native React Native related issue label Mar 14, 2024
@cwomack
Copy link
Contributor

cwomack commented Mar 15, 2024

@brentvatne, we're marking this as a feature request and are reviewing this internally as @cshfang stated above. We'll let you know if there's any further questions. Thanks!

@cwomack cwomack added feature-request Request a new feature and removed pending-triage Issue is pending triage investigating This issue is being investigated labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amazon-cognito-identity-js Used for issues related to this specific package within the monorepo feature-request Request a new feature React Native React Native related issue
Projects
None yet
Development

No branches or pull requests

4 participants