Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AzureAD number matching functionality #266

Open
vlaero opened this issue Feb 22, 2023 · 7 comments
Open

Support AzureAD number matching functionality #266

vlaero opened this issue Feb 22, 2023 · 7 comments

Comments

@vlaero
Copy link

vlaero commented Feb 22, 2023

As per https://learn.microsoft.com/en-us/azure/active-directory/authentication/how-to-mfa-number-match AzureAD is planning to switch on number matching functionality for all AzureAD tenants as of 27th Feb 2023.
I authenticate to a tenancy that has had this enabled for a few weeks now, and the workaround is to use '--mode gui'.
Unfortunately, this requires a GUI. I understand the docker variant is broken unless running with an X11 server and some changes to the launch script.
It would be very handy to be able to use aws-azure-login on a non-GUI terminal session again.
Note that the saml2aws project recently merged a PR to add AzureAD number matching support. https://github.com/Versent/saml2aws
There may be some code there that can be reviewed to determine what changes may be needed in the aws-azure-login codebase.

@MohamedAsan
Copy link
Collaborator

@vlaero Are you sure this is not fixed in v3.6.1?
I added a fix for that recently - #250

Can you upload a screen recording how the flow is in GUI mode?

@vlaero
Copy link
Author

vlaero commented Feb 24, 2023

@MohamedAsan I searched the repo and somehow didn't see that commit - sorry.
Can confirm that current version is working OK.
I was thinking that the docker container is probably the simplest way for people to consume that newest version. I noticed that the doco still points to the image in the sportradar section on docker hub.
Would it be possible to update that repo name and add a new container build?
I noticed this issue that makes a note of this too: #235

@MohamedAsan
Copy link
Collaborator

@vlaero I don't have access to the docker repo 😞

@vlaero
Copy link
Author

vlaero commented Feb 24, 2023

Possible to create another repo - ie: aws-azure-login?
Then change the documentation to refer to that?

@MohamedAsan
Copy link
Collaborator

Sure, go ahead and raise a PR :)

@jghal
Copy link
Contributor

jghal commented May 18, 2023

Unfortunately, this requires a GUI. I understand the docker variant is broken unless running with an X11 server and some changes to the launch script.

@vlaero @MohamedAsan are the changes documented somewhere? Now that wsl gui is generally available this should be doable. Is sportradar/aws-azure-login still the correct latest docker image to use? I can't see how to confirm version with that image.

@jghal
Copy link
Contributor

jghal commented Oct 20, 2023

@MohamedAsan I raised a PR :) #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants