Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node.js lambda -> aws-otel-lambda -> ADOT collector doesn't work #627

Closed
NathanNam opened this issue Jun 28, 2023 · 10 comments
Closed

node.js lambda -> aws-otel-lambda -> ADOT collector doesn't work #627

NathanNam opened this issue Jun 28, 2023 · 10 comments
Labels

Comments

@NathanNam
Copy link

NathanNam commented Jun 28, 2023

It seems node.js lambda -> aws-otel-lambda -> ADOT collector doesn't work at this moment. We tried the following combination:

  • Runtime: Node.js 18.x
  • Architecture: x86_64
  • aws-otel-lambda: aws-otel-nodejs-amd64-ver-1-13-0

Interestingly, python lambda -> aws-otel-lambda -> ADOT collector works.

  • Runtime: Python 3.8
  • Architecture: x86_64
  • aws-otel-lambda: aws-otel-python-amd64-ver-1-18-0

Given our experience with the python route, we believe there are some issues or bugs in the node.js route at this moment.

Is anyone able to use node.js lambda -> aws-otel-lambda -> ADOT collector? If so, could you share your working combination of runtime, architecture, and aws-otel-lambda?

@vsakaram
Copy link

vsakaram commented Jul 3, 2023

Can you provide some additional details on the failure that is seen to help us triage/investigate this issue better?

@NathanNam
Copy link
Author

@vsakaram Thanks for your response. I'm not sure whether you have access to this AWS support case (13151228451).

For Node.js, the automatic instrumentation (i.e. no code changes needed other than the steps outlined in https://aws-otel.github.io/docs/getting-started/lambda/lambda-js#enable-auto-instrumentation-for-your-lambda-function) is working as intended for AWS SDK V2 clients/calls but NOT for AWS SDK V3 clients/calls.

The AWS Distro for OpenTelemetry Lambda Support For JavaScript does work to automatically instrument the AWS SDK for JavaScript V2 (see screenshot Node_SDK_v2_working.png). This was tested in both Node14.x and Node 16.x .
image

However, ADOT for JavaScript doesn't work to automatically instrument the AWS SDK for JavaScript v3 in Node.js 18.x.
image

@NathanNam
Copy link
Author

@vsakaram Do you need anything else from me?

@NathanNam
Copy link
Author

@vsakaram Any updates on this one?

@paradisecy
Copy link

paradisecy commented Aug 31, 2023

any updates on this? are you planning to support aws-sdk v3 with nodejs 18 since aws is depricating aws-sdk v2 & node 14, 12 are in the deprication phase ? thanks!!

Copy link

github-actions bot commented Dec 3, 2023

This issue is stale because it has been open 90 days with no activity. If you want to keep this issue open, please just leave a comment below and auto-close will be canceled

@github-actions github-actions bot added the stale label Dec 3, 2023
@NathanNam
Copy link
Author

Any updates?

@github-actions github-actions bot removed the stale label Dec 17, 2023
@NathanNam
Copy link
Author

Has this issue been addressed?

Copy link

This issue is stale because it has been open 90 days with no activity. If you want to keep this issue open, please just leave a comment below and auto-close will be canceled

@github-actions github-actions bot added the stale label Apr 14, 2024
Copy link

This issue was closed because it has been marked as stale for 30 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants