Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 馃幐 add recordEvent to orchestration and command queue #185

Closed
wants to merge 4 commits into from
Closed

feat: 馃幐 add recordEvent to orchestration and command queue #185

wants to merge 4 commits into from

Conversation

maniator
Copy link
Contributor

@maniator maniator commented Jul 26, 2022 •
edited

Add recordEvent to RUM which will be added to the interaction telemetry on page load.

Closes #139

Example JSON sent via PutRumEvents api (in an integ test):

{
  BatchId: 'b18cb16b-47f8-4d16-a67d-831e1f17ae3c',
  AppMonitorDetails: { id: 'abc123', version: '1.0' },
  UserDetails: {
    userId: 'e77ad812-00cd-4fdb-a051-a247e5618a7b',
    sessionId: '9cd9bec8-c5f7-4e9b-a8ae-a75fad02f749'
  },
  RumEvents: [
    {
      id: 'bad26fe3-e763-4429-87de-df43b49cf917',
      timestamp: 1658867045,
      type: 'com.amazon.rum.js_general_event',
      metadata: '{"version":"1.0.0","browserLanguage":"en-US","browserName":"Chrome Headless","browserVersion":"103.0.5060.134","osName":"Mac OS","osVersion":"10.15.7","deviceType":"desktop","platformType":"web","domain":"localhost","title":"RUM Integ Test","pageId":"/js_general_event.html","interaction":0}',
      details: '{"version":"1.0.0","name":"random-event","data":"Some random event"}'
    }
  ]
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maniator maniator force-pushed the record-event branch 3 times, most recently from e667efa to 95c18cf Compare July 26, 2022 18:36
This was referenced Jul 26, 2022
Closed
Open
jsutter909
jsutter909 reviewed Jul 26, 2022
View reviewed changes
Copy link

@jsutter909 jsutter909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no real comments on the logic. There are some typos to review though. Otherwise looks great.

src/orchestration/Orchestration.ts Outdated Show resolved Hide resolved
src/orchestration/Orchestration.ts Outdated Show resolved Hide resolved
@maniator
Copy link
Contributor Author

I have no real comments on the logic. There are some typos to review though. Otherwise looks great.

Resolved 馃槃

@adebayor123 adebayor123 mentioned this pull request Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsutter909 jsutter909 jsutter909 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add log level support
2 participants
@maniator @jsutter909