Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Custom log formatter example does not show source for MyCompanyLogFormatter.ts #1256

Closed
1 task done
cromo opened this issue Jan 18, 2023 · 3 comments
Closed
1 task done
Assignees
Labels
documentation Improvements or additions to documentation duplicate This issue is a duplicate of an existing one

Comments

@cromo
Copy link

cromo commented Jan 18, 2023

What were you searching in the docs?

I was reading the docs from top to bottom and came across this since some might want to write string logs instead of using structured logging.

Is this related to an existing documentation section?

https://awslabs.github.io/aws-lambda-powertools-typescript/latest/core/logger/#custom-log-formatter-bring-your-own-formatter

How can we improve?

It looks like the source for `handler.ts` was mistakenly copied into the block below it for `utils/formatters/MyCompanyLogFormatter.ts` instead of showing an implementation of the `LogFormatterInterface`. That block should show how to implement this.

Got a suggestion in mind?

Change the utils/formatters/MyCompanyLogFormatter.ts code block to show an implementation of the LogFormatterInterface as expected; as written the documentation does little more than tell you that custom formatters can be used but not how to make them.

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@cromo cromo added documentation Improvements or additions to documentation triage This item has not been triaged by a maintainer, please wait labels Jan 18, 2023
@dreamorosi
Copy link
Contributor

Hello, thanks for reporting this.

Someone reported this yesterday #1253 and a fix was merged with #1254.

The updated/fixed version is already available on the /dev version of the docs.

The updated docs will be published on /latest tomorrow.

I'll leave the issue open until then so that others can see it if needed.

@dreamorosi dreamorosi added duplicate This issue is a duplicate of an existing one and removed triage This item has not been triaged by a maintainer, please wait labels Jan 18, 2023
@dreamorosi dreamorosi self-assigned this Jan 18, 2023
@dreamorosi
Copy link
Contributor

The updated docs are now live, you can see the code example here.

Note that if you don't see the change yet it's probably due to caching, you might need to refresh your browser's cache or try with a different browser/private session to see it immediately - but it's there!

@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation duplicate This issue is a duplicate of an existing one
Projects
None yet
Development

No branches or pull requests

2 participants