feat(logger): add cause
field to formatted error
#1617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR introduces new logic to the
LogFormatter
class to allow the Logger utility to include thecause
field to logs, when emitting a log that contains anError
. Thecause
field was added in Node.js 16 so we need to use a conditional logic to check if theError
passed in to the logger has the field or not before attempting to format it and include it in a log entry.This logic is meant to be temporary and will be removed once we drop support for Node.js 14. This is documented in the docstrings of the new code.
Once this PR is merged, customers can pass an
Error
with acause
to the logger, which will format it like so:Note that in JS it's possible to
throw
more objects than justError
, for this reason the logic also includes a checkinstanceof Error
before attempting to format thecause
. If the object is not an error it will be included as value of thecause
key as-is:Related issues, RFCs
Issue number: #1361
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.