fix(tracer): modify aws-xray-sdk-core
import for js
#2164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR modifies the imports of the
aws-xray-sdk-core
package to accommodate customers using Powertools via JavaScript rather than TypeScript. Given that these customers don't necessarily useesbuild
or other transpilers the ESM import format will case a syntax runtime error as shown in the linked issue.The customer reporting the issue has kindly provided a workaround which seems to fix the issue and it's implemented in this PR. I have run some manual tests on my machine and the issue seems to indeed have been fixed.
Related issues, RFCs
Issue number: #2163
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.