diff --git a/.gitignore b/.gitignore index 17ba70d7ac568..2f2092ed1a333 100644 --- a/.gitignore +++ b/.gitignore @@ -1,5 +1,4 @@ # VSCode extension -.vscode/ /.favorites.json # TypeScript incremental build states diff --git a/.vscode/settings.json b/.vscode/settings.json new file mode 100644 index 0000000000000..676c7b4ff8b61 --- /dev/null +++ b/.vscode/settings.json @@ -0,0 +1,8 @@ +{ + "eslint.workingDirectories": [ + { "pattern": "./packages/@aws-cdk/*" }, + { "pattern": "./packages/@monocdk-experiment/*" }, + { "pattern": "./packages/*" }, + { "pattern": "./tools/*" } + ] +} diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1e0f427499887..c3531cc3cc13a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -287,19 +287,9 @@ All packages in the repo use a standard base configuration found at [eslintrc.js This can be customized for any package by modifying the `.eslintrc` file found at its root. If you're using the VS Code and would like to see eslint violations on it, install the [eslint -extension](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint). - -The following additional [VS Code setting](https://code.visualstudio.com/docs/getstarted/settings) is required when the -entire project is opened (not required if only a specific module is opened) - - -```json -"eslint.workingDirectories": [ - { "pattern": "./packages/@aws-cdk/*" }, - { "pattern": "./packages/@monocdk-experiment/*" }, - { "pattern": "./packages/*" }, - { "pattern": "./tools/*" }, -], -``` +extension](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint). The VS Code setting [needed for +the extension to work](https://github.com/Microsoft/vscode-eslint#settings-options) on the monorepo is configured in +the [folder settings](https://code.visualstudio.com/docs/editor/multi-root-workspaces#_settings). #### pkglint diff --git a/packages/@aws-cdk/cloud-assembly-schema/package.json b/packages/@aws-cdk/cloud-assembly-schema/package.json index bd35c48cc12dc..7f5bf0b43ff8c 100644 --- a/packages/@aws-cdk/cloud-assembly-schema/package.json +++ b/packages/@aws-cdk/cloud-assembly-schema/package.json @@ -40,13 +40,6 @@ "compat": "cdk-compat", "update-schema": "bash scripts/update-schema.sh" }, - "cdk-build": { - "eslint": { - "ignore-pattern": [ - "scripts/*" - ] - } - }, "author": { "name": "Amazon Web Services", "url": "https://aws.amazon.com", diff --git a/tools/cfn2ts/package.json b/tools/cfn2ts/package.json index f435be1374daa..4aca26a5e5139 100644 --- a/tools/cfn2ts/package.json +++ b/tools/cfn2ts/package.json @@ -43,13 +43,6 @@ "jest": "^25.4.0", "pkglint": "0.0.0" }, - "cdk-build": { - "eslint": { - "ignore-pattern": [ - "test/enrichments/*.ts" - ] - } - }, "keywords": [ "aws", "cdk"