Skip to content

Commit a01678b

Browse files
authoredNov 30, 2021
feat(secretsmanager): support secrets rotation in GovCloud (#17673)
This follows the same general setup as #14608 to add Secrets Manager rotation support in the `aws-us-gov` partition, GovCloud (US). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 3623982 commit a01678b

File tree

5 files changed

+22
-0
lines changed

5 files changed

+22
-0
lines changed
 

‎.gitallowed

+2
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,5 @@ account: '919830735681' #cn-northwest-1
3232
account: '297356227824'
3333
# partition aws-cn
3434
account: '193023089310'
35+
# partition aws-us-gov
36+
account: '023102451235'

‎packages/@aws-cdk/aws-docdb/test/integ.cluster-rotation.lit.expected.json

+4
Original file line numberDiff line numberDiff line change
@@ -823,6 +823,10 @@
823823
"aws-cn": {
824824
"applicationId": "arn:aws-cn:serverlessrepo:cn-north-1:193023089310:applications/SecretsManagerMongoDBRotationSingleUser",
825825
"semanticVersion": "1.1.37"
826+
},
827+
"aws-us-gov": {
828+
"applicationId": "arn:aws-us-gov:serverlessrepo:us-gov-west-1:023102451235:applications/SecretsManagerMongoDBRotationSingleUser",
829+
"semanticVersion": "1.1.93"
826830
}
827831
}
828832
}

‎packages/@aws-cdk/aws-rds/test/integ.cluster-rotation.lit.expected.json

+4
Original file line numberDiff line numberDiff line change
@@ -846,6 +846,10 @@
846846
"aws-cn": {
847847
"applicationId": "arn:aws-cn:serverlessrepo:cn-north-1:193023089310:applications/SecretsManagerRDSMySQLRotationSingleUser",
848848
"semanticVersion": "1.1.37"
849+
},
850+
"aws-us-gov": {
851+
"applicationId": "arn:aws-us-gov:serverlessrepo:us-gov-west-1:023102451235:applications/SecretsManagerRDSMySQLRotationSingleUser",
852+
"semanticVersion": "1.1.93"
849853
}
850854
}
851855
}

‎packages/@aws-cdk/aws-rds/test/integ.instance.lit.expected.json

+4
Original file line numberDiff line numberDiff line change
@@ -1136,6 +1136,10 @@
11361136
"aws-cn": {
11371137
"applicationId": "arn:aws-cn:serverlessrepo:cn-north-1:193023089310:applications/SecretsManagerRDSOracleRotationSingleUser",
11381138
"semanticVersion": "1.1.37"
1139+
},
1140+
"aws-us-gov": {
1141+
"applicationId": "arn:aws-us-gov:serverlessrepo:us-gov-west-1:023102451235:applications/SecretsManagerRDSOracleRotationSingleUser",
1142+
"semanticVersion": "1.1.93"
11391143
}
11401144
}
11411145
},

‎packages/@aws-cdk/aws-secretsmanager/lib/secret-rotation.ts

+8
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,8 @@ export class SecretRotationApplication {
149149
return this.applicationId;
150150
} else if (partition === 'aws-cn') {
151151
return `arn:aws-cn:serverlessrepo:cn-north-1:193023089310:applications/${this.applicationName}`;
152+
} else if (partition === 'aws-us-gov') {
153+
return `arn:aws-us-gov:serverlessrepo:us-gov-west-1:023102451235:applications/${this.applicationName}`;
152154
} else {
153155
throw new Error(`unsupported partition: ${partition}`);
154156
}
@@ -163,6 +165,8 @@ export class SecretRotationApplication {
163165
return this.semanticVersion;
164166
} else if (partition === 'aws-cn') {
165167
return '1.1.37';
168+
} else if (partition === 'aws-us-gov') {
169+
return '1.1.93';
166170
} else {
167171
throw new Error(`unsupported partition: ${partition}`);
168172
}
@@ -316,6 +320,10 @@ export class SecretRotation extends CoreConstruct {
316320
applicationId: props.application.applicationArnForPartition('aws-cn'),
317321
semanticVersion: props.application.semanticVersionForPartition('aws-cn'),
318322
},
323+
'aws-us-gov': {
324+
applicationId: props.application.applicationArnForPartition('aws-us-gov'),
325+
semanticVersion: props.application.semanticVersionForPartition('aws-us-gov'),
326+
},
319327
},
320328
});
321329
const application = new serverless.CfnApplication(this, 'Resource', {

0 commit comments

Comments
 (0)
Please sign in to comment.