feat(aws-s3-deployment): log retention option (#17779)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: naseemkullah

packages/@aws-cdk/aws-s3-deployment/README.md

@@ -44,19 +44,18 @@ This is what happens under the hood:
    `websiteBucket`). If there is more than one source, the sources will be
    downloaded and merged pre-deployment at this step.
 
-
 ## Supported sources
 
 The following source types are supported for bucket deployments:
 
- - Local .zip file: `s3deploy.Source.asset('/path/to/local/file.zip')`
- - Local directory: `s3deploy.Source.asset('/path/to/local/directory')`
- - Another bucket: `s3deploy.Source.bucket(bucket, zipObjectKey)`
+- Local .zip file: `s3deploy.Source.asset('/path/to/local/file.zip')`
+- Local directory: `s3deploy.Source.asset('/path/to/local/directory')`
+- Another bucket: `s3deploy.Source.bucket(bucket, zipObjectKey)`
 
 To create a source from a single file, you can pass `AssetOptions` to exclude
 all but a single file:
 
- - Single file: `s3deploy.Source.asset('/path/to/local/directory', { exclude: ['**', '!onlyThisFile.txt'] })`
+- Single file: `s3deploy.Source.asset('/path/to/local/directory', { exclude: ['**', '!onlyThisFile.txt'] })`
 
 **IMPORTANT** The `aws-s3-deployment` module is only intended to be used with
 zip files from trusted sources. Directories bundled by the CDK CLI (by using
@@ -243,7 +242,7 @@ size of the AWS Lambda resource handler.
 
 ## EFS Support
 
-If your workflow needs more disk space than default (512 MB) disk space, you may attach an EFS storage to underlying 
+If your workflow needs more disk space than default (512 MB) disk space, you may attach an EFS storage to underlying
 lambda function. To Enable EFS support set `efs` and `vpc` props for BucketDeployment.
 
 Check sample usage below.
@@ -288,4 +287,4 @@ might be tricky to build on Windows.
 
 ## Roadmap
 
- - [ ] Support "blue/green" deployments ([#954](https://github.com/aws/aws-cdk/issues/954))
+- [ ] Support "blue/green" deployments ([#954](https://github.com/aws/aws-cdk/issues/954))

packages/@aws-cdk/aws-s3-deployment/lib/bucket-deployment.ts

@@ -4,6 +4,7 @@ import * as ec2 from '@aws-cdk/aws-ec2';
 import * as efs from '@aws-cdk/aws-efs';
 import * as iam from '@aws-cdk/aws-iam';
 import * as lambda from '@aws-cdk/aws-lambda';
+import * as logs from '@aws-cdk/aws-logs';
 import * as s3 from '@aws-cdk/aws-s3';
 import * as cdk from '@aws-cdk/core';
 import { AwsCliLayer } from '@aws-cdk/lambda-layer-awscli';
@@ -101,6 +102,14 @@ export interface BucketDeploymentProps {
    */
   readonly distributionPaths?: string[];
 
+
+  /**
+   * The number of days that the lambda function's log events are kept in CloudWatch Logs.
+   *
+   * @default logs.RetentionDays.INFINITE
+   */
+  readonly logRetention?: logs.RetentionDays;
+
   /**
    * The amount of memory (in MiB) to allocate to the AWS Lambda function which
    * replicates the files from the CDK bucket to the destination bucket.
@@ -297,6 +306,7 @@ export class BucketDeployment extends CoreConstruct {
         accessPoint,
         mountPath,
       ) : undefined,
+      logRetention: props.logRetention,
     });
 
     const handlerRole = handler.role;

packages/@aws-cdk/aws-s3-deployment/package.json

@@ -92,6 +92,7 @@
     "@aws-cdk/aws-efs": "0.0.0",
     "@aws-cdk/aws-iam": "0.0.0",
     "@aws-cdk/aws-lambda": "0.0.0",
+    "@aws-cdk/aws-logs": "0.0.0",
     "@aws-cdk/aws-s3": "0.0.0",
     "@aws-cdk/aws-s3-assets": "0.0.0",
     "@aws-cdk/core": "0.0.0",
@@ -106,6 +107,7 @@
     "@aws-cdk/aws-efs": "0.0.0",
     "@aws-cdk/aws-iam": "0.0.0",
     "@aws-cdk/aws-lambda": "0.0.0",
+    "@aws-cdk/aws-logs": "0.0.0",
     "@aws-cdk/aws-s3": "0.0.0",
     "@aws-cdk/aws-s3-assets": "0.0.0",
     "@aws-cdk/core": "0.0.0",

packages/@aws-cdk/aws-s3-deployment/test/bucket-deployment.test.ts

@@ -1,9 +1,10 @@
-import '@aws-cdk/assert-internal/jest';
 import * as path from 'path';
 import { MatchStyle, objectLike } from '@aws-cdk/assert-internal';
+import '@aws-cdk/assert-internal/jest';
 import * as cloudfront from '@aws-cdk/aws-cloudfront';
 import * as ec2 from '@aws-cdk/aws-ec2';
 import * as iam from '@aws-cdk/aws-iam';
+import * as logs from '@aws-cdk/aws-logs';
 import * as s3 from '@aws-cdk/aws-s3';
 import { testDeprecated, testFutureBehavior } from '@aws-cdk/cdk-build-tools';
 import * as cdk from '@aws-cdk/core';
@@ -75,6 +76,22 @@ test('deploy from local directory asset', () => {
   });
 });
 
+test('deploy with configured log retention', () => {
+  // GIVEN
+  const stack = new cdk.Stack();
+  const bucket = new s3.Bucket(stack, 'Dest');
+
+  // WHEN
+  new s3deploy.BucketDeployment(stack, 'Deploy', {
+    sources: [s3deploy.Source.asset(path.join(__dirname, 'my-website'))],
+    destinationBucket: bucket,
+    logRetention: logs.RetentionDays.ONE_WEEK,
+  });
+
+  // THEN
+  expect(stack).toHaveResourceLike('Custom::LogRetention', { RetentionInDays: 7 });
+});
+
 test('deploy from local directory assets', () => {
   // GIVEN
   const stack = new cdk.Stack();