-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Comparing changes
Open a pull request
base repository: aws/aws-cdk
base: v1.134.0
head repository: aws/aws-cdk
compare: v1.135.0
Commits on Nov 23, 2021
-
chore: note about code snippets that uses consumers (#17645)
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Niranjan Jayakar authoredNov 23, 2021 Configuration menu - View commit details
-
Copy full SHA for 9eedaa0 - Browse repository at this point
Copy the full SHA 9eedaa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b45be32 - Browse repository at this point
Copy the full SHA b45be32View commit details -
chore(ecs): undeprecate Cluster.addCapacity (#17652)
The `Cluster.addCapacity` method was deprecated in #14386 as part of the introduction of `Cluster.addAsgCapacityProvider`. However, the corresponding `ClusterProps.capacity` property and `AddCapacityOptions` interface were not deprecated, leading to a confusing mismash of deprecated and undeprecated usage. The README for ECS still heavily references `Cluster.addCapacity`, further leading to potential confusion for users just following the module's guidance. As part of cleaning up deprecated usage as part of the lead-up to the V2 launch, opting to un-deprecate the `addCapacity` method rather than deprecating the other two elements and rewriting the README. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 765c274 - Browse repository at this point
Copy the full SHA 765c274View commit details -
fix(s3-deployment): updating memoryLimit or vpc results in stack upda…
…te failure (#17530) This fixes the issue where updating the memoryLimit or vpc of the BucketDeployment resource would result in a stack update failure. In order to fix this the ID of the BucketDeployment CustomResource includes info on the memoryLimit and vpc in the same way that the Lambda function does. This means that when either of these values are updated, the BucketDeployment CustomResource will be recreated along with the Lambda function. If anyone is setting `retainOnDelete=false` (default is `true`) then this change would result in the data in the bucket being deleted. In order to avoid this scenario, this PR introduces a bucket tag that controls whether or not a BucketDeployment resource can delete data from the bucket. The BucketDeployment resource will now add a tag to the deployment bucket with a format like `aws-cdk:cr-owned:{keyPrefix}:{uniqueHash}`. For example: ``` { Key: 'aws-cdk:cr-owned:deploy/here/:240D17B3', Value: 'true', } ``` Each bucket+keyPrefix can be "owned" by 1 or more BucketDeployment resources. Since there are some scenarios where multiple BucketDeployment resources can deploy to the same bucket and key prefix (e.g. using include/exclude) we also append part of the id to make the key unique. As long as a bucket+keyPrefix is "owned" by a BucketDeployment resource, another CR cannot delete data. There are a couple of scenarios where this comes into play. 1. If the LogicalResourceId of the CustomResource changes (e.g. memoryLimit is updated) CloudFormation will first issue a 'Create' to create the new CustomResource and will update the Tag on the bucket. CloudFormation will then issue a 'Delete' on the old CustomResource and since the new CR "owns" the Bucket+keyPrefix (indicated by the presence of the tag), the old CR will not delete the contents of the bucket 2. If the BucketDeployment resource is deleted _and_ it is the only CR for that bucket+keyPrefix then CloudFormation will first remove the tag from the bucket and then issue a "Delete" to the CR. Since there are no tags indicating that this bucket+keyPrefix is "owned" then it will delete the contents. 3. If the BucketDeployment resource is deleted _and_ it is *not* the only CR for that bucket:keyPrefix then CloudFormation will first remove the tag from the bucket and then issue a "Delete" to the CR. Since there are other CRs that also "own" that bucket+keyPrefix (indicated by the presence of tags), there will still be a tag on the bucket and the contents will not be removed. The contents will only be removed after _all_ BucketDeployment resource that "own" the bucket+keyPrefix have been removed. 4. If the BucketDeployment resource _and_ the S3 Bucket are both removed, then CloudFormation will first issue a "Delete" to the CR and since there is a tag on the bucket the contents will not be removed. If you want the contents of the bucket to be removed on bucket deletion, then `autoDeleteObjects` property should be set to true on the Bucket. Scenario 3 & 4 are changes to the existing functionality in that they now do *not* delete data in some scenarios when they did previously. fixes #7128 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 2ba40d1 - Browse repository at this point
Copy the full SHA 2ba40d1View commit details -
chore(aws-cdk-lib): change description and keywords (#17654)
This is done with the express purpose of improving its discoverability on Construct Hub. ---- Changed the description and added keywords *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 82ce371 - Browse repository at this point
Copy the full SHA 82ce371View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc5dde9 - Browse repository at this point
Copy the full SHA fc5dde9View commit details -
chore(merge-back): 1.134.0 (#17661)
See [CHANGELOG](https://github.com/aws/aws-cdk/blob/merge-back/1.134.0/CHANGELOG.md)
Configuration menu - View commit details
-
Copy full SHA for ddf2881 - Browse repository at this point
Copy the full SHA ddf2881View commit details
Commits on Nov 24, 2021
-
chore(rds): undeprecated APIs whose migration will cause interruption (…
…#17683) All deprecated APIs will be removed from CDKv2. Migrating from `SnapshotCredentials.fromGeneratedPassword()` to its documented alternative will modify the RDS instance in ways that may impact usability of the resource. This API must not be deprecated. The alternative APIs to the `DatabaseInstanceEngine` APIs refereced in this PR will cause the [CFN EngineVersion][1] to be modified. Modification of this property causes [some interruption][2] to the resource. This may cause "some interruption" to users' running applications. [1]: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-rds-database-instance.html#cfn-rds-dbinstance-engineversion [2]: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/using-cfn-updating-stacks-update-behaviors.html#update-some-interrupt ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Niranjan Jayakar authoredNov 24, 2021 Configuration menu - View commit details
-
Copy full SHA for 797edbd - Browse repository at this point
Copy the full SHA 797edbdView commit details -
feat(custom-resources): fixed Lambda function name (#17670)
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 5710fe5 - Browse repository at this point
Copy the full SHA 5710fe5View commit details -
fix(pipelines): stack outputs used in stackSteps not recognized (#17311)
fixes #17272 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 5e4a219 - Browse repository at this point
Copy the full SHA 5e4a219View commit details -
feat(iam): support
fromGroupName()
for IAM groups (#17243)IAM Policies and Users already support import by name. Extending same for Groups ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 29b379c - Browse repository at this point
Copy the full SHA 29b379cView commit details -
fix(core): bundling skipped with --exclusively option and stacks unde…
…r stage (#17210) We were comparing bundling stacks of the form `Stage/Stack` with stack names of the form `Stage-Stack`. For stacks with `NodejsFunction`s this leads to assets containing the whole CDK project because when bundling is skipped the asset references the source directory which is the project root. Closes #12898 Closes #15346 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for cda6601 - Browse repository at this point
Copy the full SHA cda6601View commit details -
feat(ec2): add r6i instances (#17663)
New R6I instances just got released: https://aws.amazon.com/about-aws/whats-new/2021/11/amazon-ec2-r6i-instances/ Docs have already been updated: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 0138292 - Browse repository at this point
Copy the full SHA 0138292View commit details -
feat(cloudfront): Add support for response headers policy (#17359)
feat(cloudfront): Add support for response headers policy closes #17290 Notes: ~1. Currently the CFNSpec is not up-to-date with the latest available cloudformation changes for `ResponseHeadersPolicyId` in `AWS::CloudFront::Distribution CacheBehavior`. Some aspects of the same are added to the PR but are left commented. Would update the PR once the spec is updated.~ Refs: 1. https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/adding-response-headers.html 2. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudfront-responseheaderspolicy.html 3. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-cachebehavior.html#cfn-cloudfront-distribution-cachebehavior-responseheaderspolicyid ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for ea0acff - Browse repository at this point
Copy the full SHA ea0acffView commit details -
chore: npm-check-updates && yarn upgrade (#17687)
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
Configuration menu - View commit details
-
Copy full SHA for 6c7550b - Browse repository at this point
Copy the full SHA 6c7550bView commit details -
feat(s3): support Transfer Acceleration (#17636)
Add support for S3 [Transfer Acceleration](https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html). This PR introduces: - New boolean property `transferAcceleration` to enable Transfer Acceleration. - New operation `transferAccelerationUrlForObject()` to get HTTPS endpoint for Transfer Acceleration. Closes #12570. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for b432822 - Browse repository at this point
Copy the full SHA b432822View commit details -
feat(stepfunctions-tasks): add 'Emr on Eks' tasks (#17103)
This CDK feature adds support for Emr on Eks by implementing API service integrations for the following three APIs. This PR adds three tasks which support Emr on Eks: 1) [Create Virtual Cluster](https://docs.aws.amazon.com/emr-on-eks/latest/APIReference/API_CreateVirtualCluster.html) 2) [ Start a job run](https://docs.aws.amazon.com/emr-on-eks/latest/APIReference/API_StartJobRun.html) 3) [Delete virtual cluster ](https://docs.aws.amazon.com/emr-on-eks/latest/APIReference/API_DeleteVirtualCluster.html) Continuation of #15262 by @matthewsvu and @BenChaimberg: Closes #15234. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for f2bf322 - Browse repository at this point
Copy the full SHA f2bf322View commit details -
feat(iot): add Action to capture CloudWatch metrics (#17503)
I'm trying to implement aws-iot L2 Constructs. This PR is one of steps after following PR: - #16681 (comment) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for ec4187c - Browse repository at this point
Copy the full SHA ec4187cView commit details -
feat(docdb): implement audit and profiler logs (#17570)
closes #17478 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 4982aca - Browse repository at this point
Copy the full SHA 4982acaView commit details
Commits on Nov 25, 2021
-
feat(servicecatalog): Add TagOptions to a CloudformationProduct (#17672)
Users can now associate TagOptions to a cloudformation product through an association call or upon instantiation. TagOptions added to a portfolio are made available for any products within it, but you can also have separate, product level tag options. We only create unique TagOption constructs in the template but we can have the same Tag Option associated with both a portfolio and a product in that portfolio, the logic that resolves this is handled by service catalog. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* Co-authored-by: Dillon Ponzo <dponzo18@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2d19e15 - Browse repository at this point
Copy the full SHA 2d19e15View commit details -
fix(docdb): secret rotation ignores excluded characters in password (#…
Configuration menu - View commit details
-
Copy full SHA for 1fe2215 - Browse repository at this point
Copy the full SHA 1fe2215View commit details -
fix(codepipeline): cannot trigger on all tags anymore in EcrSourceAct…
…ion (#17270) The EcrSourceAction could previously be used to trigger on changes to all tags of an image. As part of the fix #13818, the imageTag was defaulted to latest if not provided. Therefore it was no longer possible to call the underlying onCloudTrailImagePushed function with an undefined imageTag to watch changes on all tags. Reintroduce triggering on all tags by passing an empty string as the imageTag. Fixes #13818 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 39fe11b - Browse repository at this point
Copy the full SHA 39fe11bView commit details -
fix(assert): support multiline strings with
stringLike()
(#17692)Updates the `RegExp` constructor to support multiline. Resolves #17691 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 37596e6 - Browse repository at this point
Copy the full SHA 37596e6View commit details -
feat(apigateway): step functions integration (#16827)
- Added StepFunctionsRestApi and StepFunctionsIntegration implementation closes #15081. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for cb31547 - Browse repository at this point
Copy the full SHA cb31547View commit details -
docs: add links to CloudFormation documentation to READMEs (#17696)
Currently, the documentation of our CFN-only libraries leaves a lot to be desired, which is confusing users. Update the READMEs to make it very clear that we don't have anything for them, and point them to the right location for getting documentation. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for b03b4dc - Browse repository at this point
Copy the full SHA b03b4dcView commit details -
chore(assertions): snippets avoid using intermediate variable assignm…
…ent (#17714) Previously, the rosetta translations could not determine the type of objects being passed into methods when they are untyped. Some were being interpreted as 'props' type while they should just be regarding as `Record` or `any`. To compensate for this, the README in this module assigned them to variables, so the translator did a better job at knowing this. This has now been fixed in rosetta. Move back to using this inline, since the usage is just nicer. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Niranjan Jayakar authoredNov 25, 2021 Configuration menu - View commit details
-
Copy full SHA for 9d436a0 - Browse repository at this point
Copy the full SHA 9d436a0View commit details -
chore(apigatewayv2): remove dependency of "http" from "common" (#17715)
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Niranjan Jayakar authoredNov 25, 2021 Configuration menu - View commit details
-
Copy full SHA for b8a4a9a - Browse repository at this point
Copy the full SHA b8a4a9aView commit details -
chore(aws-cdk-lib): prevent deep imports (#17707)
Sometimes, IDEs like VSCode will autocomplete deep imports into the CDK library. For example, they may generate the following: ```ts import { Bucket } from 'aws-cdk-lib/aws-s3/lib/bucket'; ``` Whereas the correct import should have been: ```ts import { Bucket } from 'aws-cdk-lib/aws-s3'; ``` If we allow people to write the former, they will be broken every time we change the internal file layout of our module (or conversely, we will not be allowed to change the file layout at all). Use the `package.json` `"exports"` mechanism to advertise the select paths that users are allowed to import from, and disallow the rest. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 53620e9 - Browse repository at this point
Copy the full SHA 53620e9View commit details
Commits on Nov 26, 2021
-
feat(ec2): add mac1 instance (#17677)
`mac1` instances got released last year: https://aws.amazon.com/about-aws/whats-new/2021/10/amazon-ec2-mac-instances-additional-regions/ Docs have already been updated a while ago: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype Note: Whenever `mac2` comes out (probably on M1, or most likely on M1Pro/M1Max) we'll have to update `InstanceArchitecture` enum [here](https://github.com/aws/aws-cdk/blob/ddf2881ee24cbf3083463a6e772a5c91acc229aa/packages/%40aws-cdk/aws-ec2/lib/instance-types.ts#L573). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 88a5204 - Browse repository at this point
Copy the full SHA 88a5204View commit details -
feat(cfnspec): cloudformation spec v49.0.0 (#17727)
Co-authored-by: AWS CDK Team <aws-cdk@amazon.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7e0c9a3 - Browse repository at this point
Copy the full SHA 7e0c9a3View commit details -
fix(cli): S3 asset uploads are rejected by commonly referenced encryp…
…tion SCP (introduces bootstrap stack v9) (#17668) Many organizations around the world have started to use a specific Service Control Policy (SCP) from this blog post: https://aws.amazon.com/blogs/security/how-to-prevent-uploads-of-unencrypted-objects-to-amazon-s3/ in order to make sure all S3 bucket uploads are encrypted. CDK configures the `DefaultEncryptionConfiguration` on the bucket so that objects are always encrypted by default, but this specific SCP can only check that individual upload actions include the "enable encryption" option. That means that even though the end result would still be satisfied (objects are encrypted in S3), the SCP would nevertheless reject the CDK upload. We would rather people use AWS Config to make sure all buckets have `DefaultEncryptionConfiguration` set, so that this SCP is not necessary... but there is no arguing with deployed reality. Change the CDK upload code path to first read out the default encryption configuration from the bucket, only to then mirror those exact same settings in the `PutObject` call so that the SCP can see that they are present. This requires adding a new permission to the `cdk-assets` role, namely `s3:GetEncryptionConfiguration`, so requires a new bootstrap stack version: version 9. If you want this new behavior because your organization applies this specific SCP, you must upgrade to bootstrap stack version 9. If you do not care about this new behavior you don't have to do anything: if the call to `getEncryptionConfiguration` fails, the CDK will fall back to the old behavior (not specifying any header). Fixes #11265. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 8191f1f - Browse repository at this point
Copy the full SHA 8191f1fView commit details -
fix(apigatewayv2): integration class does not render an integration r…
…esource (#17729) Routes on APIGateway V2 can integrate with different backends. This is achieved by creating the CFN resource `AWS::ApiGatewayV2::Integration` that is then referenced in the resource for the Route. Currently, the `IHttpRouteIntegration` (and `IWebSocketRouteIntegration`) interface represents a unique backend that a route can integrate with, using the CDK "bind" pattern. An integration can be bound to any number of routes but should be rendered into a single instance of `AWS::ApiGatewayV2::Integration` resource. To achieve this currently, the `HttpApi` (and `WebSocketApi`) class holds a cache of all integrations defined against its routes. This is the wrong level of caching and causes a number of problems. 1. We rely on the configuration of the `AWS::ApiGateway::Integration` resource to determine if one already exists. This means that two instances of `IHttpRouteIntegration` can result in rendering only one instance of `AWS::ApiGateway::Integration` resource. Users may want to intentionally generate multiple instances of `AWS::ApiGateway::Integration` classes with the same configuration. Taking away this power with CDK "magic" is just confusing. 2. Currently, we allow using the same instance of `IHttpRouteIntegration` (or `IWebSocketRouteIntegration`) to be bound to routes in different `HttpApi`. When bound to the route, the CDK renders an instance of `AWS::ApiGatewayV2::Integration` for each API. This is another "magic" that has the potential for user confusion and bugs. The solution is to KeepItSimple™. Remove the API level caching and simply cache at the level of each integration. This ensures that each instance of `HttpRouteIntegration` (previously `IHttpRouteIntegration`) renders to exactly one instance of `AWS::ApiGatewayV2::Integration`. Disallow using the same instance of `HttpRouteIntegration` across different instances of `HttpApi`. fixes #13213 BREAKING CHANGE: The interface `IHttpRouteIntegration` is replaced by the abstract class `HttpRouteIntegration`. * **apigatewayv2:** The interface `IWebSocketRouteIntegration` is now replaced by the abstract class `WebSocketRouteIntegration`. * **apigatewayv2:** Previously, we allowed the usage of integration classes to be used with routes defined in multiple `HttpApi` instances (or `WebSocketApi` instances). This is now disallowed, and separate instances must be created for each instance of `HttpApi` or `WebSocketApi`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Niranjan Jayakar authoredNov 26, 2021 Configuration menu - View commit details
-
Copy full SHA for 3b5b97a - Browse repository at this point
Copy the full SHA 3b5b97aView commit details -
feat(lambda): function construct exposes configured timeout (#17594)
Supersedes #17000. I didn't realise that the "allow edits by maintainers" was not supported under organisation accounts, so I've forked under my account instead. Otherwise, these changes are the same as the linked PR. Thanks! 👍 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 87fd60f - Browse repository at this point
Copy the full SHA 87fd60fView commit details -
fix(codepipeline): cross-env pipeline cannot be created in
Stage
(#……17730) Because a cross-environment pipeline cannot be created in `Stage`, it cannot be deployed using CDK Pipelines. The error is: ``` Error: You cannot add a dependency from 'AAA' (in Stage 'BBB') to 'CCC' (in the App): dependency cannot cross stage boundaries ``` Root cause is that the `Pipeline` construct creates a support stack in the `App` scope, which is outside its containing `Stage`, and hence the dependency crosses stage boundaries. Fixes #17643. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for f17f29e - Browse repository at this point
Copy the full SHA f17f29eView commit details -
chore(cognito): docs showed incorrect default value for preventUserEx…
…istenceErrors (#17667) The docs for preventUserExistenceErrors showed a default of `true` when the default has always been `false`. Update the docs to reflect the actual default. Also remove references to "new stacks" since the functionality is the same between new and existing stacks. fixes #17044 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for efaaaf5 - Browse repository at this point
Copy the full SHA efaaaf5View commit details -
feat(ecs-service-extensions): Auto scaling for Queue Extension (#17430)
---- This PR adds target tracking auto scaling policy for the the SQS Queues provided to and created by the `QueueExtension` (in the `useService()` hook). The auto scaling is based on `backlogPerTask` custom metric which is emitted by an AWS Lambda Function. The PR also contains this Lambda Function and its tests. *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for df7b9b4 - Browse repository at this point
Copy the full SHA df7b9b4View commit details
Commits on Nov 29, 2021
-
chore(deps): bump actions/cache from 2.1.6 to 2.1.7 (#17745)
Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/releases">actions/cache's releases</a>.</em></p> <blockquote> <h2>v2.1.7</h2> <p>Support 10GB cache upload using the latest version <code>1.0.8</code> of <a href="https://www.npmjs.com/package/@actions/cache"><code>@actions/cache</code> </a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/cache/commit/937d24475381cd9c75ae6db12cb4e79714b926ed"><code>937d244</code></a> bumping up action version to 2.1.7 (<a href="https://github-redirect.dependabot.com/actions/cache/issues/683">#683</a>)</li> <li><a href="https://github.com/actions/cache/commit/eb0698d1c508f8573fddfe25566f10a4b1344504"><code>eb0698d</code></a> Bumping up <code>@actions/cache</code> version to 1.0.8 (<a href="https://github-redirect.dependabot.com/actions/cache/issues/682">#682</a>)</li> <li><a href="https://github.com/actions/cache/commit/67b6d52d50609f6166e3ea1d8872aca3a4763bd2"><code>67b6d52</code></a> (R renv) Remove unused renv-cache-path variable (<a href="https://github-redirect.dependabot.com/actions/cache/issues/663">#663</a>)</li> <li><a href="https://github.com/actions/cache/commit/92f67a482915a145e9372ed84b9e7f13538ecc69"><code>92f67a4</code></a> (R renv) Fix Renv package cache location in examples (<a href="https://github-redirect.dependabot.com/actions/cache/issues/660">#660</a>)</li> <li><a href="https://github.com/actions/cache/commit/6bbe742add91b3db4abf110e742a967ec789958f"><code>6bbe742</code></a> Use existing check-dist implementation (<a href="https://github-redirect.dependabot.com/actions/cache/issues/618">#618</a>)</li> <li><a href="https://github.com/actions/cache/commit/c9db520cf31dc27e42864cc3687b0d70284cc5fc"><code>c9db520</code></a> Create check-dist.yml (<a href="https://github-redirect.dependabot.com/actions/cache/issues/604">#604</a>)</li> <li><a href="https://github.com/actions/cache/commit/10906ba9cd642bcc07f0f38a95a57e5c1361d156"><code>10906ba</code></a> Bump ws from 5.2.2 to 5.2.3 (<a href="https://github-redirect.dependabot.com/actions/cache/issues/610">#610</a>)</li> <li><a href="https://github.com/actions/cache/commit/2ebdcff279bac9704c2b319b25ac54b63d6800c2"><code>2ebdcff</code></a> Add "see more" link to GHE-not-supported warning (<a href="https://github-redirect.dependabot.com/actions/cache/issues/609">#609</a>)</li> <li><a href="https://github.com/actions/cache/commit/5807af2642b6ffc80df306359122fd0ff9b571b8"><code>5807af2</code></a> Fix bugs in example of how to use with pipenv (<a href="https://github-redirect.dependabot.com/actions/cache/issues/607">#607</a>)</li> <li><a href="https://github.com/actions/cache/commit/0638051e9af2c23d10bb70fa9beffcad6cff9ce3"><code>0638051</code></a> Golang example tweak - add <code>go-build</code> path - rebuild page TOC (<a href="https://github-redirect.dependabot.com/actions/cache/issues/577">#577</a>)</li> <li>See full diff in <a href="https://github.com/actions/cache/compare/v2.1.6...v2.1.7">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Configuration menu - View commit details
-
Copy full SHA for 171cbc1 - Browse repository at this point
Copy the full SHA 171cbc1View commit details -
fix(aws-elasticloadbalancingv2): Set stickiness.enabled unless target…
Configuration menu - View commit details
-
Copy full SHA for 168a98f - Browse repository at this point
Copy the full SHA 168a98fView commit details -
feat(ec2): explicit mapPublicIpOnLaunch configuration for public subn…
…ets (#17346) **Issue (Fixes #14194, #16838 When creating a VPC you can define a SubnetConfiguration but it is not possible to define `mapPublicIpOnLaunch` for public subnets. VPC Example: ``` const vpc = new ec2.Vpc(this, 'vpc-id', { maxAzs: 2, subnetConfiguration: [ { name: 'private-subnet-1', subnetType: ec2.SubnetType.PRIVATE, cidrMask: 24, }, { name: 'public-subnet-1', subnetType: ec2.SubnetType.PUBLIC, cidrMask: 24, }, ] }); ``` Proposal: ``` const vpc = new ec2.Vpc(this, 'vpc-id', { maxAzs: 2, subnetConfiguration: [ { name: 'private-subnet-1', subnetType: ec2.SubnetType.PRIVATE, cidrMask: 24, }, { name: 'public-subnet-1', subnetType: ec2.SubnetType.PUBLIC, cidrMask: 24, mapPublicIpOnLaunch: false, // or true }, ] }); ```
Configuration menu - View commit details
-
Copy full SHA for a1685c6 - Browse repository at this point
Copy the full SHA a1685c6View commit details -
chore(apigatewayv2): integration api re-organization (#17752)
There are three major changes. `HttpRouteIntegration` (and its sibling `WebSocketRouteIntegration`) creates a CDK construct (`HttpIntegration` and `WebSocketIntegration`) as part of its bind operation. The id to this CDK construct is determined by hashing the results of the bind. Using hashes makes the construct id fragile/sensitive, consequently the CFN resource's logical id fragile. The fragility comes mainly from the question - have we hashed all of the expected properties that should be hashed, and nothing extra? If we have not hashed properties that should be there, or hashed too much, we end up with a hash change, hence resource replacement that is unexpected. This commit changes this approach and asks the user to provide the construct's id. This is more aligned with the current CDK expectation that users provide an id when initializing constructs. We just don't have a good way to validate that our hashing is accurate, so let's not do it at all. This change makes the user provide a unique name within a scope, which is already a standard requirement for CDK constructs. Secondly, the ergonomics of specific integration implementations, such as, `LambdaProxyIntegration`, `HttpAlbIntegration`, etc. is modified so that the integrating primitive is moved out of the 'props', and to the constructor. The API ergonomics of this feels much better than having to always provide a 'props'. Since this package contains constructs around both http api and websocket api, the convention to follow is that all classes specific to the former will be prefixed with `Http` and the latter will be prefixed with `WebSocket`. Bring the integration classes `LambdaProxyIntegration` and `HttpProxyIntegration` in line with this convention. These are renamed to `HttpLambdaIntegration` and `HttpUrlIntegration` respectively. BREAKING CHANGE: The `HttpIntegration` and `WebSocketIntegration` classes require an "id" parameter to be provided during its initialization. * **apigatewayv2-integrations:** The `LambdaWebSocketIntegration` is now renamed to `WebSocketLambdaIntegration`. The new class accepts the handler to the target lambda function directly in its constructor. * **apigatewayv2-integrations:** `HttpProxyIntegration` and `HttpProxyIntegrationProps` are now renamed to `HttpUrlIntegration` and `HttpUrlIntegrationProps` respectively. The new class accepts the target url directly in its constructor. * **apigatewayv2-integrations:** `LambdaProxyIntegration` and `LambdaProxyIntegrationProps` are now renamed to `HttpLambdaIntegration` and `HttpLambdaIntegrationProps` respectively. The new class accepts the lambda function handler directly in its constructor. * **apigatewayv2-integrations:** `HttpAlbIntegration` now accepts the ELB listener directly in its constructor. * **apigatewayv2-integrations:** `HttpNlbIntegration` now accepts the ELB listener directly in its constructor. * **apigatewayv2-integrations:** `HttpServiceDiscoveryIntegration` now accepts the service discovery Service directly in its constructor. * **apigatewayv2-authorizers:** `UserPoolAuthorizerProps` is now renamed to `HttpUserPoolAuthorizerProps`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Niranjan Jayakar authoredNov 29, 2021 Configuration menu - View commit details
-
Copy full SHA for 29039e8 - Browse repository at this point
Copy the full SHA 29039e8View commit details
Commits on Nov 30, 2021
-
chore: avoid runtime dependency between cfnspec and pkglint (#17751)
Our build pipeline is currently failing because `cfnspec` (which is a public package) takes a runtime dependency on `pkglint` (which is a private package). This was introduced in #17696. To resolve this, we moved the functionality that generates new L1 library code from `lib/` to `build-tools/` since it's only needed in CDK build context (technically this is breaking public API, but we could not see any use case for external users to generate L1 modules in CDK-repository format). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Elad Ben-Israel authoredNov 30, 2021 Configuration menu - View commit details
-
Copy full SHA for 5fc0141 - Browse repository at this point
Copy the full SHA 5fc0141View commit details -
chore(generate-examples): generate fixtures (#17737)
Motivation: we want the ability for `rosetta:extract` to be called after `generate-examples`. Currently, this results in errors because the generated examples are only stored in the assembly, and only the visible source, so they fail compilation when we attempt to extract them. Solution: while we generate examples, we also generate a fixture per assembly, `_generated.ts-fixture`, that stores the necessary import statement for compilation. Then, when we later (might) call extract, we have a fixture to place the example in. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 446f5fd - Browse repository at this point
Copy the full SHA 446f5fdView commit details -
feat(ec2): add vt1 instances (#17756)
`vt1` instances release note: https://aws.amazon.com/blogs/aws/new-amazon-ec2-vt1-instances-for-live-multi-stream-video-transcoding/ Docs have already been updated a while ago: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 245c059 - Browse repository at this point
Copy the full SHA 245c059View commit details -
feat(ec2): add m6a instances (#17764)
New `m6a` instances release notes: https://aws.amazon.com/blogs/aws/new-amazon-ec2-m6a-instances-powered-by-3rd-gen-amd-epyc-processors/  CFN docs have already been updated: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for b06f120 - Browse repository at this point
Copy the full SHA b06f120View commit details -
feat(ec2): add g5g instances (#17765)
New `g5g` instances release notes: https://aws.amazon.com/blogs/aws/new-amazon-ec2-g5g-instances-powered-by-aws-graviton2-processors-and-nvidia-t4g-tensor-core-gpus/  Docs have already been updated a while ago: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 1799f7e - Browse repository at this point
Copy the full SHA 1799f7eView commit details -
chore(apigatewayv2-authorizers): re-organize authorizer api (#17772)
This is a follow on to a previous commit 29039e8. Update the ergonomics of the authorizer construct APIs to be aligned with the rest of the module, specifically the integration construct APIs. The API now takes the construct id and the integration target as part of the constructor, instead of in the props class. In most cases, except in the case of jwt, all properties in the props struct become optional, which improves API ergonomics. It also removes the need for `authorizerName` property to be required. BREAKING CHANGE: The default value for the prop `authorizerName` in `HttpJwtAuthorizerProps` has changed. * **apigatewayv2-authorizers:** `HttpJwtAuthorizer` now takes the construct id and the target jwt issuer as part of its constructor. * **apigatewayv2-authorizers:** `HttpLambdaAuthorizer` now takes the construct id and the target lambda function handler as part of its constructor. * **apigatewayv2-authorizers:** The default value for the prop `authorizerName` in `HttpUserPoolAuthorizerProps` has changed. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Niranjan Jayakar authoredNov 30, 2021 Configuration menu - View commit details
-
Copy full SHA for 719f33e - Browse repository at this point
Copy the full SHA 719f33eView commit details -
feat(ec2): extend BastionHostLinux to support CloudFormationInit (#17507
) Implements #17161 Extends the `BastionHostLinux` constructor to accept optional `CloudFormationInit` and `ApplyCloudFormationInitOptions` arguments to be passed to the underlying instance. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for c62377e - Browse repository at this point
Copy the full SHA c62377eView commit details -
fix(apprunner): startCommand and environment are ignored in imageConf…
…iguration (#16939) This PR addresses the following issues 1. custom environment variables and start commands should be allowed for `imageConfiguration` 2. buildCommand, environment and startCommand should be allowed for `codeConfigurationValues` Fixes: #16812 - [x] add tests - [x] implementation ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for d911c58 - Browse repository at this point
Copy the full SHA d911c58View commit details -
feat(neptune): add engine version 1.1.0.0 and instance types t4g, r6g (…
…#17669) Add new instance types general-purpose T4g and memory-optimized R6g (see [announcement](https://aws.amazon.com/about-aws/whats-new/2021/11/aws-graviton2-based-instances-amazon-neptune/)). The specific instance types were copied from the [pricing page](https://aws.amazon.com/de/neptune/pricing/). Add new Neptune engine version 1.1.0.0 which was part of the announcement, too. Deployment tested successfully in region us-east-1: ```ts new neptune.DatabaseCluster(this, 'Database', { vpc, instanceType: neptune.InstanceType.T4G_MEDIUM, engineVersion: neptune.EngineVersion.V1_1_0_0, }); new neptune.DatabaseCluster(this, 'Database2', { vpc, instanceType: neptune.InstanceType.R6G_LARGE, engineVersion: neptune.EngineVersion.V1_1_0_0, }); ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 83e669d - Browse repository at this point
Copy the full SHA 83e669dView commit details -
fix(lambda-nodejs): bundling with
nodeModules
fails with paths cont…Configuration menu - View commit details
-
Copy full SHA for 986f291 - Browse repository at this point
Copy the full SHA 986f291View commit details
There are no files selected for viewing
Large diffs are not rendered by default.
This file was deleted.
Large diffs are not rendered by default.