Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backup): enable WindowsVss Backup #15934

Merged
merged 33 commits into from
Dec 1, 2021
Merged

feat(backup): enable WindowsVss Backup #15934

merged 33 commits into from
Dec 1, 2021
+63 −0

Conversation

cokia
Copy link
Contributor

@cokia cokia commented Aug 7, 2021 •
edited by kaizencc
Loading

Closes #14803.
Reference Pull Request : #14891

Lets you set the 'WindowsVss' option when you create a new backup plan like this:

const plan = new BackupPlan(stack, 'Plan', {
  windowsVss: true,
});

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 7, 2021

@cokia
Copy link
Contributor Author

cokia commented Aug 7, 2021

Comment: I couldn't modify the Readme for this because there was no content for the const plan = new BackupPlan.

@peterwoodworth peterwoodworth added effort/small Small work item – less than a day of effort @aws-cdk/aws-backup Related AWS Backup labels Aug 11, 2021
@cokia
Copy link
Contributor Author

cokia commented Aug 29, 2021 •
edited
Loading

@BenChaimberg I know you're busy, but please check the Pull request once.
Thank you!

BenChaimberg
BenChaimberg previously requested changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@BenChaimberg BenChaimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a section to the README detailing this feature

@cokia @BenChaimberg
fix: change backupOption to windowsVss
67f898f 
Co-authored-by: Ben Chaimberg <youppi3@gmail.com>
@mergify mergify bot dismissed BenChaimberg’s stale review September 4, 2021 13:46

Pull request has been modified.

@cokia
Copy link
Contributor Author

cokia commented Sep 6, 2021

@BenChaimberg I resolved some issue.
Please check it one more time. Thank you :)

BenChaimberg
BenChaimberg previously requested changes Sep 9, 2021
View reviewed changes
@cokia @BenChaimberg
Update packages/@aws-cdk/aws-backup/lib/plan.ts
be553a9 
Co-authored-by: Ben Chaimberg <youppi3@gmail.com>
@mergify mergify bot dismissed BenChaimberg’s stale review September 9, 2021 23:10

Pull request has been modified.

@kaizencc kaizencc assigned kaizencc and unassigned BenChaimberg Sep 22, 2021
@kaizencc kaizencc added the p2 label Oct 22, 2021
@kaizencc
Copy link
Contributor

@cokia any updates on this? Are you still able to continue this PR?

@kaizencc
Copy link
Contributor

@cokia I will look through this PR next week. Thanks for your patience.

@kaizencc
Copy link
Contributor

although the build is still failing so please take a look at that first.

kaizencc
kaizencc previously requested changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments @cokia

@fitzoh fitzoh mentioned this pull request Nov 25, 2021
Closed
2 tasks
cokia and others added 2 commits November 26, 2021 13:53
@cokia @kaizencc
Update packages/@aws-cdk/aws-backup/README.md
87b840f 
Co-authored-by: kaizen3031593 <36202692+kaizen3031593@users.noreply.github.com>
@cokia @kaizencc
Update packages/@aws-cdk/aws-backup/lib/plan.ts
e3a98fe 
Co-authored-by: kaizen3031593 <36202692+kaizen3031593@users.noreply.github.com>
@mergify mergify bot dismissed kaizencc’s stale review November 26, 2021 04:54

Pull request has been modified.

@cokia
Copy link
Contributor Author

cokia commented Dec 1, 2021

All modifications have been reflected.

Thank you for your help until I finish this PR. Please check it out for the last time!

@kaizen3031593

kaizencc
kaizencc approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @cokia!

@kaizencc kaizencc changed the title feat(backup): advancedBackupSettings feat(backup): enable WindowsVss Backup Dec 1, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 8885bdf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 12fcb18 into aws:master Dec 1, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@cokia cokia deleted the backup-support-advancedBackupSettings branch December 1, 2021 22:43
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@cokia @TikiTDO
feat(backup): enable WindowsVss Backup (aws#15934)
721d234 
Closes aws#14803.
Reference Pull Request : aws#14891 

Lets you set the 'WindowsVss' option when you create a new backup plan like this:

```ts
const plan = new BackupPlan(stack, 'Plan', {
  windowsVss: true,
});
```
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc

@G3N3R4LE4RL G3N3R4LE4RL

@BenChaimberg BenChaimberg

Assignees

@kaizencc kaizencc

Labels
@aws-cdk/aws-backup Related AWS Backup effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(backup): Support for advancedBackupSettings
6 participants
@cokia @kaizencc @aws-cdk-automation @BenChaimberg @G3N3R4LE4RL @peterwoodworth