Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipelines): stack outputs used in stackSteps not recognized #17311

Merged
merged 6 commits into from
Nov 24, 2021
Merged

fix(pipelines): stack outputs used in stackSteps not recognized #17311

merged 6 commits into from
Nov 24, 2021

Conversation

bmmin
Copy link
Contributor

@bmmin bmmin commented Nov 3, 2021

fixes #17272


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 3, 2021

@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Nov 3, 2021
bmmin added 2 commits November 5, 2021 08:03

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@blimmer blimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! I'm currently using patch-package to get this behavior and it's working without problems.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@rix0rrr rix0rrr changed the title fix(pipelines): recognize stack output usage in stackSteps fix(pipelines): stack outputs used in stackSteps not recognized Nov 24, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mergify mergify bot merged commit 5e4a219 into aws:master Nov 24, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 26dc023
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

beezly pushed a commit to beezly/aws-cdk that referenced this pull request Nov 29, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…17311)

fixes aws#17272


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…17311)

fixes aws#17272


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/pipelines CDK Pipelines library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdk-pipelines: deploy outputs not usable if only referenced from stack step
5 participants