Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDS: change parameterGroup prop for DatabaseInstanceReadReplica #17580

Closed
2 tasks
marcmoy opened this issue Nov 19, 2021 · 3 comments · Fixed by #17822
Closed
2 tasks

RDS: change parameterGroup prop for DatabaseInstanceReadReplica #17580

marcmoy opened this issue Nov 19, 2021 · 3 comments · Fixed by #17822
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. p2

Comments

@marcmoy
Copy link

marcmoy commented Nov 19, 2021 •
edited
Loading

Description

I would like to apply a different database parameter group to the replica instance that is different than the source database instance.

Use Case

The source and replica instances may have different clients who may require different database parameter group settings.

Proposed Solution

Add a new parameterGroup option for DatabaseInstanceReadReplicaProps when creating a new DatabaseInstanceReadReplica instance.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@marcmoy marcmoy added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 19, 2021
@skinny85
Copy link
Contributor

Thanks for opening the issue @marcmoy!

@jogold do you know if is this actually supported by RDS? I assume DatabaseInstanceReadReplicaProps not having a parameterGroup: ParameterGroup property is not a coincidence 😜.

Thanks,
Adam

@skinny85 skinny85 changed the title DatabaseInstanceReadReplica: Add parameterGroup prop for replica RDS: change parameterGroup prop for DatabaseInstanceReadReplica Nov 19, 2021
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Nov 19, 2021
@skinny85 skinny85 added effort/small Small work item – less than a day of effort p2 labels Nov 19, 2021
@skinny85 skinny85 removed their assignment Nov 19, 2021
@jogold
Copy link
Contributor

jogold commented Dec 2, 2021

is not a coincidence 😜.

not a coincidence, a mistake I think 😄

It looks like it is supported.

jogold added a commit to jogold/aws-cdk that referenced this issue Dec 3, 2021
@jogold
feat(rds): parameter group for replica instances
049a20c 
Move `parameterGroup` from `DatabaseInstanceSourceProps` to
`DatabaseInstanceNewProps` since the parameter group of a replica
instance can be customized.

Closes aws#17580
@jogold jogold mentioned this issue Dec 3, 2021
Merged
@mergify mergify bot closed this as completed in #17822 Dec 3, 2021
mergify bot pushed a commit that referenced this issue Dec 3, 2021
@jogold
feat(rds): parameter group for replica instances (#17822)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
b606a23 
Move `parameterGroup` from `DatabaseInstanceSourceProps` to
`DatabaseInstanceNewProps` since the parameter group of a replica
instance can be customized.

Closes #17580


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

eastNine pushed a commit to eastNine/aws-cdk that referenced this issue Dec 5, 2021
@jogold @eastNine
feat(rds): parameter group for replica instances (aws#17822)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
d61bca9 
Move `parameterGroup` from `DatabaseInstanceSourceProps` to
`DatabaseInstanceNewProps` since the parameter group of a replica
instance can be customized.

Closes aws#17580


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@jogold @TikiTDO
feat(rds): parameter group for replica instances (aws#17822)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
79ccc98 
Move `parameterGroup` from `DatabaseInstanceSourceProps` to
`DatabaseInstanceNewProps` since the parameter group of a replica
instance can be customized.

Closes aws#17580


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rds): parameter group for replica instances jogold/aws-cdk
3 participants
@skinny85 @jogold @marcmoy