feat(lambda): function construct exposes configured timeout #17594
+72
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rix0rrr
reviewed
Nov 19, 2021
| @@ -725,6 +731,7 @@ export class Function extends FunctionBase { | |||
| }); | |||
|
|
|||
| this.runtime = props.runtime; | |||
| this.timeout = props.timeout; | |||
There was a problem hiding this comment.
Why not reify this to the 3 seconds we promised it would be if unset?
There was a problem hiding this comment.
@rix0rrr See previous discussion: #17000 (comment)
nija-at
approved these changes
Nov 24, 2021
nija-at
previously requested changes
Nov 24, 2021
mergify
bot
dismissed
nija-at’s stale review
Pull request has been modified.
|
@nija-at Sure thing, have fixed. 🙂 |
nija-at
approved these changes
Nov 26, 2021
nija-at
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
beezly
pushed a commit
to beezly/aws-cdk
that referenced
this pull request
Nov 29, 2021
Supersedes aws#17000. I didn't realise that the "allow edits by maintainers" was not supported under organisation accounts, so I've forked under my account instead. Otherwise, these changes are the same as the linked PR. Thanks! 👍 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
pedrosola
pushed a commit
to pedrosola/aws-cdk
that referenced
this pull request
Dec 1, 2021
Supersedes aws#17000. I didn't realise that the "allow edits by maintainers" was not supported under organisation accounts, so I've forked under my account instead. Otherwise, these changes are the same as the linked PR. Thanks! 👍 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
2 tasks
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Supersedes aws#17000. I didn't realise that the "allow edits by maintainers" was not supported under organisation accounts, so I've forked under my account instead. Otherwise, these changes are the same as the linked PR. Thanks! 👍 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #17000.
I didn't realise that the "allow edits by maintainers" was not supported under organisation accounts, so I've forked under my account instead. Otherwise, these changes are the same as the linked PR.
Thanks! 👍
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license