Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): add r6i instances #17663

Merged
merged 4 commits into from
Nov 24, 2021
Merged

feat(ec2): add r6i instances #17663

merged 4 commits into from
Nov 24, 2021

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Nov 23, 2021

New R6I instances just got released:

https://aws.amazon.com/about-aws/whats-new/2021/11/amazon-ec2-r6i-instances/

Docs have already been updated:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Nov 23, 2021
@gitpod-io
Copy link

gitpod-io bot commented Nov 23, 2021

@pahud
Copy link
Contributor

pahud commented Nov 24, 2021

Hi @neilkuan @dwchiang @ChenKuanSun are you interested to take a look as an initial review? Please leave a review comment with "LGTM" if you think it's good with you.

Thanks.

Copy link
Contributor

@neilkuan neilkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@clarencetw clarencetw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ChenKuanSun added a commit to ChenKuanSun/aws-cdk that referenced this pull request Nov 24, 2021
Add r6i instances in instance test

relate PR aws#17663
Copy link

@ChenKuanSun ChenKuanSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

added instances check #17675

@neilkuan
Copy link
Contributor

Hi @robertd, Can you also add testing in packages/@aws-cdk/aws-ec2/test/instance.test.ts at this PR?!

@pahud
Copy link
Contributor

pahud commented Nov 24, 2021

@njlynch wdyt?

@njlynch njlynch added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Nov 24, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 7a553f0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0138292 into aws:master Nov 24, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

beezly pushed a commit to beezly/aws-cdk that referenced this pull request Nov 29, 2021
New R6I instances just got released:

https://aws.amazon.com/about-aws/whats-new/2021/11/amazon-ec2-r6i-instances/

Docs have already been updated:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@robertd robertd deleted the add-r6i-instances branch January 20, 2022 16:05
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
New R6I instances just got released:

https://aws.amazon.com/about-aws/whats-new/2021/11/amazon-ec2-r6i-instances/

Docs have already been updated:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants