Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@aws-cdk/aws-lambda-event-sources: Support for SQS ReportBatchItemFailures #17690

Closed
2 tasks
rcoundon opened this issue Nov 24, 2021 · 1 comment · Fixed by #17733
Closed
2 tasks

@aws-cdk/aws-lambda-event-sources: Support for SQS ReportBatchItemFailures #17690

rcoundon opened this issue Nov 24, 2021 · 1 comment · Fixed by #17733
Assignees
@njlynch
Labels
@aws-cdk/aws-sqs Related to Amazon Simple Queue Service effort/medium Medium work item – several days of effort feature/service-integration Add functionality to an L2 construct to enable easier integration with another service feature-request A feature should be added or improved. p1

Comments

@rcoundon
Copy link

Description

The documentation here for using lambda with SQS states that it's possible to configure the lambda event source with ReportBatchItemFailures in the FunctionResponseTypes list.
However this is not present in the CDK event source mapping.

Use Case

We need to be able to specify which messages failed so that successfully processed messages aren't refetched in a retry batch.

Proposed Solution

Add ReportBatchItemFailures in the FunctionResponseTypes list as per documentation

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@rcoundon rcoundon added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 24, 2021
@github-actions github-actions bot added the @aws-cdk/aws-sqs Related to Amazon Simple Queue Service label Nov 24, 2021
@peterwoodworth peterwoodworth added feature/service-integration Add functionality to an L2 construct to enable easier integration with another service effort/medium Medium work item – several days of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 24, 2021
@ChristopheBougere ChristopheBougere mentioned this issue Nov 26, 2021
Merged
@mergify mergify bot closed this as completed in #17733 Nov 30, 2021
mergify bot pushed a commit that referenced this issue Nov 30, 2021
@ChristopheBougere
feat(lambda-event-sources): sqs: support reportBatchItemFailures (#17733
3623982 
)

Fixes #17690

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

pedrosola pushed a commit to pedrosola/aws-cdk that referenced this issue Dec 1, 2021
@ChristopheBougere
feat(lambda-event-sources): sqs: support reportBatchItemFailures (aws…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
d2feda1 
…#17733)

Fixes aws#17690

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@ChristopheBougere @TikiTDO
feat(lambda-event-sources): sqs: support reportBatchItemFailures (aws…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
b764260 
…#17733)

Fixes aws#17690

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-sqs Related to Amazon Simple Queue Service effort/medium Medium work item – several days of effort feature/service-integration Add functionality to an L2 construct to enable easier integration with another service feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lambda-event-sources): sqs: support reportBatchItemFailures
3 participants
@njlynch @rcoundon @peterwoodworth