feat(assertions): major improvements to the capture feature #17713
+372
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are multiple targets (say, Resource in the CloudFormation template) that matches the given condition, any `Capture` defined in the condition will contain only the last matched resource. Convert the `Capture` class into an iterable so all matching values can be retrieved.
github-actions
bot
added
the
@aws-cdk/assertions
rix0rrr
reviewed
Nov 25, 2021
added 2 commits
November 26, 2021 10:50
|
|
rix0rrr
approved these changes
Nov 30, 2021
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Prepare the result to be analyzed. | ||
| * Analyzing results before the finalize() API is called may be inaccurate in some cases. |
There was a problem hiding this comment.
That is a weak statement. Should be made stronger (it's not allowed to analyze results before calling this?)
There was a problem hiding this comment.
Does it make sense to get hasFailed() etc on this having been called first?
So that it cannot be misused?
added 2 commits
December 2, 2021 10:21
nija-at
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
There are three major changes around the capture feature of assertions. Firstly, when there are multiple targets (say, Resource in the CloudFormation template) that matches the given condition, any `Capture` defined in the condition will contain only the last matched resource. Convert the `Capture` class into an iterable so all matching values can be retrieved. Secondly, add support to allow sub-patterns to be specified to the `Capture` class. This allows further conditions be specified, via Matchers or literals, when a value is to be captured. Finally, this fixes a bug with the current implementation where `Capture` contains the results of the last matched section, irrespective of whether that section matched with the rest of the matcher or not. fixes aws#17009 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three major changes around the capture feature of assertions.
Firstly, when there are multiple targets (say, Resource in the
CloudFormation template) that matches the given condition, any
Capturedefined in the condition will contain only the last matchedresource.
Convert the
Captureclass into an iterable so all matching values canbe retrieved.
Secondly, add support to allow sub-patterns to be specified to the
Captureclass. This allows further conditions be specified, viaMatchers or literals, when a value is to be captured.
Finally, this fixes a bug with the current implementation where
Capturecontains the results of the last matched section, irrespectiveof whether that section matched with the rest of the matcher or not.
fixes #17009
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license