feat(core): add applyRemovalPolicy to IResource #17746
Conversation
|
|
| const stack = new Stack(); | ||
| const parent = new Parent(stack, 'Parent'); | ||
|
|
||
| parent.child.applyRemovalPolicy(RemovalPolicy.RETAIN); |
There was a problem hiding this comment.
Not sure I understand the point of having parent here? I think we can just test const child = new Child(app, 'Child'); child.applyRemovalPolicy(RemovalPolicy.RETAIN);?
There was a problem hiding this comment.
The parent is necessary because the point is to have applyRemovalPolicy available on resources which are typed with IResource. If I only instantiate the child, it's just a Resource, therefore it always had the applyResourcePolicy method attached.
There was a problem hiding this comment.
So, can we do const child: IResource = new Child(...? 🙂
There was a problem hiding this comment.
Thanks! That works 🙂 Updated
skinny85
changed the title
skinny85
changed the title
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
skinny85
added
the
pr-linter/exempt-readme
|
Hey @skinny85, is there something I can do for this PR? Or is this just waiting on some spare time? 🙂 |
Nope, just Mergify dismissed my previous approval for some reason, and I didn't notice that 🙂. Thanks again for the contribution! |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The motivation behind this change is in both the linked issue and the added test case: change removal policy of a child resource with an interface type. Thanks @skinny85 for pointing me in the right direction. Closes aws#17728 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The motivation behind this change is in both the linked issue and the added test case: change removal policy of a child resource with an interface type.
Thanks @skinny85 for pointing me in the right direction.
Closes #17728
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license