-
Notifications
You must be signed in to change notification settings - Fork 4.1k
(sqs): add SSE queue encryption for SQS #17770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I checked the documentation. This feature is currently not supported by CloudFormation. |
Thanks for the feature request, @blockvote , and the link to the CloudFormation tracker @jumic! |
I'd also like to propose that SSE becomes the default for queues, and that queues that don't have KMS encryption enabled, get it enabled by default after the rollout. This affects me because at present, the Any Lambda functions that use this behaviour will have their DLQs show up in AWS Security Hub because they don't have encryption at rest enabled. |
I notice that the underlying CloudFormation support appears to be in place now (see comment), but (at time of writing) that the CloudFormation documentation hasn't been updated to reflect this, and the issue hasn't been commented on by the CloudFormation team. aws-cloudformation/cloudformation-coverage-roadmap#989 (comment) I assume that means we can't proceed until there's clarity. Perhaps internal to AWS there's a process for nudging this along? It looks like a zombie feature at the moment. |
@otaviomacedo I'm not sure, if somebody from the CDK team has read @a-h's reply. |
Add [SQS managed server side encryption](https://aws.amazon.com/about-aws/whats-new/2021/11/amazon-sqs-server-side-encryption-keys-sse/) for SQS queues. The implementation uses the new CloudFormation attribute `SqsManagedSseEnabled` ([CloudFormation documentation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sqs-queue.html#cfn-sqs-queue-sqsmanagedsseenabled)). Closes #17770. ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [X] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [X] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Add [SQS managed server side encryption](https://aws.amazon.com/about-aws/whats-new/2021/11/amazon-sqs-server-side-encryption-keys-sse/) for SQS queues. The implementation uses the new CloudFormation attribute `SqsManagedSseEnabled` ([CloudFormation documentation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sqs-queue.html#cfn-sqs-queue-sqsmanagedsseenabled)). Closes aws#17770. ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [X] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [X] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add [SQS managed server side encryption](https://aws.amazon.com/about-aws/whats-new/2021/11/amazon-sqs-server-side-encryption-keys-sse/) for SQS queues. The implementation uses the new CloudFormation attribute `SqsManagedSseEnabled` ([CloudFormation documentation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sqs-queue.html#cfn-sqs-queue-sqsmanagedsseenabled)). Closes aws#17770. ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [X] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [X] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Description
Currently you can only only select the following queue encryptions:
However, via AWS Console you can also select SSE encryption.
Use Case
We use S3 events, that are automatically forwarded to SQS, but that doesn't work with KMS encryption, but it does with SSE (we tried this via AWS console).
Proposed Solution
Add a new option
SSE
toQueueEncryption
:aws-cdk/packages/@aws-cdk/aws-sqs/lib/queue.ts
Line 192 in 29039e8
Other information
No response
Acknowledge
The text was updated successfully, but these errors were encountered: