Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-nodejs): bundling fails with a file dependency in nodeModules #17851

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Dec 5, 2021

If the dependency version is a file:, find its absolute path so that
we can install it in the temporary bundling folder.

Closes #17830


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ules`

If the dependency version is a `file:`, find its absolute path so that
we can install it in the temporary bundling folder.

Closes aws#17830
@gitpod-io
Copy link

gitpod-io bot commented Dec 5, 2021

@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 69662c1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5737c33 into aws:master Dec 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…ules` (aws#17851)

If the dependency version is a `file:`, find its absolute path so that
we can install it in the temporary bundling folder.

Closes aws#17830


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@aws-cdk/aws-lambda-nodejs: bundling fails when adding a workspace or file to nodeModules list
3 participants