-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ec2): add vpcName property to the VPC #17940
Conversation
@njlynch Do I need to update the README for this small change? |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
**Issue** When creating a VPC you can not define the VPC name. The current way to set the name is using the `Tags` class **VPC Example:** ```javascript const vpc = new ec2.Vpc(this, 'vpc-id', { maxAzs: 2, subnetConfiguration: [ { name: 'private-subnet-1', subnetType: ec2.SubnetType.PRIVATE, cidrMask: 24, }, { name: 'public-subnet-1', subnetType: ec2.SubnetType.PUBLIC, cidrMask: 24, }, ] }); cdk.Tags.of(vpc).add('Name', 'CustomVPCName'); ``` **Proposal:** ```javascript const vpc = new ec2.Vpc(this, 'vpc-id', { maxAzs: 2, subnetConfiguration: [ { name: 'private-subnet-1', subnetType: ec2.SubnetType.PRIVATE, cidrMask: 24, }, { name: 'public-subnet-1', subnetType: ec2.SubnetType.PUBLIC, cidrMask: 24, mapPublicIpOnLaunch: false, // or true }, ], vpcName: 'CustomVPCName', }); ``` *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Issue
When creating a VPC you can not define the VPC name. The current way to set the name is using the
Tags
classVPC Example:
Proposal:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license