Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(@aws-cdk/aws-codecommit): Include CodeCommit Repo initialization via S3 in L2 construct #17967

Closed
1 of 2 tasks
LukvonStrom opened this issue Dec 11, 2021 · 1 comment · Fixed by #17968
Closed
1 of 2 tasks

(@aws-cdk/aws-codecommit): Include CodeCommit Repo initialization via S3 in L2 construct #17967

LukvonStrom opened this issue Dec 11, 2021 · 1 comment · Fixed by #17968
Labels
@aws-cdk/aws-codecommit Related to AWS CodeCommit effort/medium Medium work item – several days of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2

Comments

@LukvonStrom
Copy link
Contributor

Description

At the moment it is only possible to initialize a codecommit repo via the underlying CfnRepository and by orchestrating the asset deployment on one's own.

Implementing it on one's own leads to bugs, such as #16958.

The heavy lifting of this action should be done by the L2 Repository construct instead.

Use Case

This feature would be neat to provide a "self-unpacking" stack with cdk-pipelines on the first deploy.
At the moment the flow of CDK pipelines requires me to init a code source (like Codecommit) first (or push content via git to it once created via CDK) and keep it in sync with my local version while deploying first time, as otherwise my pipeline would inevitably fail.

It might also be great for a variety of other usecases, such as rolling out a baseline of code into diverse repos to allow teams to utilize proven foundations.

Proposed Solution

Extend the Repository construct to take an asset as construct parameter, deploy it via CDK assets and setup permissions etc.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@LukvonStrom LukvonStrom added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 11, 2021
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Dec 11, 2021
@LukvonStrom LukvonStrom changed the title (@aws-cdk/aws-codecommit): Include Repo initialization via S3 in L2 construct (@aws-cdk/aws-codecommit): Include CodeCommit Repo initialization via S3 in L2 construct Dec 11, 2021
@github-actions github-actions bot added the @aws-cdk/aws-codecommit Related to AWS CodeCommit label Dec 11, 2021
@LukvonStrom LukvonStrom mentioned this issue Dec 11, 2021
Merged
@skinny85 skinny85 added effort/medium Medium work item – several days of effort in-progress This issue is being actively worked on. p2 feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs and removed @aws-cdk/aws-s3 Related to Amazon S3 needs-triage This issue or PR still needs to be triaged. labels Dec 13, 2021
@mergify mergify bot closed this as completed in #17968 Dec 14, 2021
mergify bot pushed a commit that referenced this issue Dec 14, 2021
@LukvonStrom
feat(codecommit): allow initializing a Repository with contents (#17968)
54b6cc6 
This repo introduces new properties to the constructor signature of the codecommit L2 Repository.
It allows users to upload code when creating a codecommit repository by leveraging the aws-s3-assets lib.
The user is able to upload whole directories at the moment.

The behaviour has a unit tests, and an integration test, which is passing (verified manually as well).

Closes #17967, provides a possible fix to #16958

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@LukvonStrom @TikiTDO
feat(codecommit): allow initializing a Repository with contents (aws#…
6dc53c1 
…17968)

This repo introduces new properties to the constructor signature of the codecommit L2 Repository.
It allows users to upload code when creating a codecommit repository by leveraging the aws-s3-assets lib.
The user is able to upload whole directories at the moment.

The behaviour has a unit tests, and an integration test, which is passing (verified manually as well).

Closes aws#17967, provides a possible fix to aws#16958

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-codecommit Related to AWS CodeCommit effort/medium Medium work item – several days of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codecommit): allow initializing a Repository with contents
3 participants
@otaviomacedo @skinny85 @LukvonStrom