feat(route53): fromPublicHostedZoneAttributes method with zoneName

[peterwoodworth]

fixes #18700

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

• This PR adds new unconventional dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use cdk-integ to deploy the infrastructure and generate the snapshot (i.e. cdk-integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[comcalvi]

Conditional approval on adding the README changes.

[peterwoodworth]

Wasn't expecting an approval so fast haha, was gonna add that soon!

I also want to add testing for this, but I'm not sure what the best way to test this is - the other import methods aren't tested. If they were, we'd need to either test it in route53 and add elasticloadbalancingV2 as a dependency or vice versa. This is because the only construct which uses an IPublicHostedZone that I can find that uses zoneName prop is VpcEndpointServiceDomainName which requires you to create a NLB

Will that as simple as just adding the dependency to the package.json file in the respective package? I tried that at first but ran into some weird errors about not being able to export Cfn properties

[peterwoodworth]

@comcalvi in case this doesn't end up in your queue otherwise 😛

[comcalvi]

Yep, you should be able to add @aws-cdk/aws-elasticloadbalancingv2 as a dependency of route53 by adding it to the dependencies section of the package.json and running yarn install --frozen-lockfile. It would be awesome if you added testing for these methods.

[peterwoodworth]

Added testing in elbv2 package due to what I assume is creating a circular dependency when I add the elbv2 package to route53

[peterwoodworth]

Added testing in elbv2 package due to what I assume is creating a circular dependency when I add the elbv2 package to route53

[peterwoodworth]

... don't look at what the title used to be 🤦🏻

[peterwoodworth]

@comcalvi can you take a quick look at this at some point to make sure it's all good with the recent additions? I don't want to just remove the label and let this go through without you taking another look.

[comcalvi]

This looks almost perfect, but can you add one test that verifies the behavior of fromPublicHostedZoneId()? I know that method already existed, but we should have had tests for it before.

[peterwoodworth]

Added one @comcalvi 👍🏻

added test

[comcalvi]

Looks great!

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: a499edb
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).