fix: deploy monitor count is off if there are > 100 changes #20067
+45
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deployment monitor failed to account for the fact the `DescribeChangeSet` operation returns a paginated output, and only represents up to 100 changes per pages. Since only the first page was considered, the progress bar would always start with a value of 101 (or less), instead of the correct count. This aggregates the `Changes` arrays from all pages of the change set description so the count is correct.
RomainMuller
added
pr-linter/exempt-readme
|
|
rix0rrr
approved these changes
Apr 25, 2022
github-actions
bot
added
bug
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
The deployment monitor failed to account for the fact the `DescribeChangeSet` operation returns a paginated output, and only represents up to 100 changes per pages. Since only the first page was considered, the progress bar would always start with a value of 101 (or less), instead of the correct count. This aggregates the `Changes` arrays from all pages of the change set description so the count is correct. Fixes aws#11805 ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deployment monitor failed to account for the fact the
DescribeChangeSetoperation returns a paginated output, and onlyrepresents up to 100 changes per pages.
Since only the first page was considered, the progress bar would always
start with a value of 101 (or less), instead of the correct count.
This aggregates the
Changesarrays from all pages of the change setdescription so the count is correct.
Fixes #11805
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license