-
Notifications
You must be signed in to change notification settings - Fork 4.1k
(aws-cdk): cdk bootstrap prints YAML template even when using --json option #21456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I was able to effectively re-bootstrap (update) the bucket by using |
These options aren't going to show changes because they make use of CloudFormation parameters. Supplying a different parameter will not show a difference in the template. The
|
…ion (#21852) Fix for the issue #21456. Added support of `--json` option for `cdk bootstrap --show-template` command. `cdk bootstrap --show-template` - will print YAML template `cdk bootstrap --show-template --json` - will print JSON template **How I tested it locally?** - Prepared a package with fix with `yarn package` and installed with `npm install -g dist/js/aws-cdk-0.0.0.tgz` - Reproduced steps from the bug #21456 - Ensured that the issue is fixed ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Hi @peterwoodworth and @rantoniuk , I prepared a fix and it was already merged, perhaps we could resolve this issue. |
|
Describe the bug
OK, I'm either stupid and I'm missing something obvious or the command --show-template doesn't behave like it should.
The below commands are always printing the same template for me:
Why? There is no
--dry-run-
option, so I expect to be able to see the template modified with the CLI options to validate before actual deployment. Instead, even-j
does not have any effect whatsoever for me. Am I missing something?Also, in the template I see that it's possible to use AWS_MANAGED_KEY for
FileAssetsBucketKmsKeyId
.Shouldn't this be possible to enable this via CLI (and be documented in cdk bootstrap -h) ?
I even tried to do the following:
cdk bootstrap --show-template > template
cdk bootstrap --cloudformation-execution-policies arn:aws:iam::aws:policy/AdministratorAccess aws://XXX/eu-west-1 --template template --no-execute
Result:
CDKToolkit: creating CloudFormation changeset... Environment bootstrapped (no changes).
CDK CLI Version
2.35.0 (build 5c23578)
Framework Version
No response
Node.js Version
v14.19.3
OS
MacOS
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: