feat(logs): add dimensions to metric filter

[iRoachie]

Allows attaching dimensions to a metric filter.

Uses the API design suggested by @marcogrcr in his comment which is agreed on.

resolves #16999

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[iRoachie]

@rix0rrr, @peterwoodworth could you review this?

[TheRealAmazonKendra]

Thank you for your contribution! This looks great, I just have a few comments inline.

Also, please make sure that your PR body describes the problem the PR is solving, and the design approach and alternatives considered. Explain why the PR solves the problem. A link to an issue is helpful, but does not replace an explanation of your thought process (See Contributing Guide, Pull Requests)

Pull request has been modified.

[iRoachie]

Updated the description of the pull request

Pull request has been modified.

[TheRealAmazonKendra]

Putting this back in change requested to reflect the status.

Pull request has been modified.

[iRoachie]

@TheRealAmazonKendra Changes made

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 9e1a5ca
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[msambol]

@iRoachie I can't seem to get this to work, with a less than helpful error returned by CFN. It deploys if I remove dimensions. Posting here first but happy to move this to an issue if necessary.

        new logs.MetricFilter(this, 'Example', {
          logGroup: lambda.logGroup,
          metricNamespace: namingPrefix,
          metricName: metricOne,
          filterPattern: logs.FilterPattern.allTerms('[SUCCESS]'),
          metricValue: '1',
          dimensions: {
            'LambdaFunctionName': '$.lambdaFunctionName'
          }
        })

Error:

Resource handler returned message: "Invalid request provided: AWS::Logs::MetricFilter" (RequestToken: redacted, HandlerErrorCode: InvalidRequest)

CDK version:

❯ cdk --version                                            
2.55.0 (build 077d77d)

[msambol]

Closing the loop here, I figured this out with help from the console. I believe the reason my example above didn't work is because of my filter pattern. In the console you see: Dimensions – only applicable for JSON or delimited filter patterns.

[rosmcmahon]

Alarms don't seem to trigger when a dimension is included in the metric it's created with?