fix(elbv2): Use correct format for parsing imported target group ARNs #22153
+95
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
FYI - Ignore the PR Linter right now. |
|
@Mergifyio update |
✅ Branch has been successfully updated |
corymhall
previously approved these changes
Sep 21, 2022
|
@Mergifyio update |
✅ Branch has been successfully updated |
mergify
bot
dismissed
corymhall’s stale review
Pull request has been modified.
corymhall
approved these changes
Sep 23, 2022
|
@Mergifyio update |
✅ Branch has been successfully updated |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The Pull Request Linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.
PRs must pass status checks before we can provide a meaningful review.
corymhall
changed the title
corymhall
added
the
pr-linter/exempt-integ-test
github-actions
bot
dismissed
their stale review
Pull Request updated. Dissmissing previous PRLinter Review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this pull request
Dec 1, 2022
…aws#22153) Currently, the following CDK snippet results in outputting the target group ID, not the target group name. ```typescript const importedTgArn = cdk.Fn.importValue('ImportTargetGroupArn'); const importedTg = elbv2.ApplicationTargetGroup.fromTargetGroupAttributes(stack, 'ImportedTg', { targetGroupArn: importedTgArn, }); new cdk.CfnOutput(stack, 'TargetGroupOutput', { value: importedTg.targetGroupName, }); ``` For example, for a sample target group ARN: ``` arn:aws:elasticloadbalancing:us-west-2:123456789012:targetgroup/MyTargetGroupName/6a58f7d61e2151d4 ``` The stack above will output `6a58f7d61e2151d4` instead of the desired `MyTargetGroupName`. This change fixes the ARN format used for parsing the imported ARN value. It does not impact any existing CDK code passing a raw ARN string (as confirmed by existing unit tests), only CDK code trying to pass tokens such as import values. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following CDK snippet results in outputting the target group ID, not the target group name.
For example, for a sample target group ARN:
The stack above will output
6a58f7d61e2151d4instead of the desiredMyTargetGroupName.This change fixes the ARN format used for parsing the imported ARN value. It does not impact any existing CDK code passing a raw ARN string (as confirmed by existing unit tests), only CDK code trying to pass tokens such as import values.
All Submissions:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license