fix(init): freshly generated go project doesn't build #22310
Conversation
JSII import is required since the code uses `jsii.String()`
|
|
There was a problem hiding this comment.
The Pull Request Linter fails with the following errors:
❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
PRs must pass status checks before we can provide a meaningful review.
aws-cdk-automation
dismissed
their stale review
Pull Request updated. Dissmissing previous PRLinter Review.
There was a problem hiding this comment.
The Pull Request Linter fails with the following errors:
❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
PRs must pass status checks before we can provide a meaningful review.
ghost
added
the
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
Pull Request updated. Dissmissing previous PRLinter Review.
ghost
closed this
ghost
reopened this
ghost
dismissed
aws-cdk-automation’s stale review
this PR does not require changes to an integration test; pr-linter/exempt-test tag added
ghost
added
the
pr-linter/exempt-integ-test
ghost
dismissed
aws-cdk-automation’s stale review
also needed to be excluded from integration test
|
How has this been manually tested? |
|
@TheRealAmazonKendra Added reproduction/test steps. |
TheRealAmazonKendra
changed the title
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The import for `jsii` is commented out, but `jsii.Close()` is called in the code, so the project won't build. Unommented the `jsii` import. To reproduce or test: ``` mkdir hello-cdk cd hello-cdk cdk init --language go go get go build ``` The `go build` step fails with `.\hello-cdk.go:32:8: undefined: jsii` before the fix, succeeds afterward. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)
The import for `jsii` is commented out, but `jsii.Close()` is called in the code, so the project won't build. Unommented the `jsii` import. To reproduce or test: ``` mkdir hello-cdk cd hello-cdk cdk init --language go go get go build ``` The `go build` step fails with `.\hello-cdk.go:32:8: undefined: jsii` before the fix, succeeds afterward. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)
The import for
jsiiis commented out, butjsii.Close()is called in the code, so the project won't build. Unommented thejsiiimport.To reproduce or test:
The
go buildstep fails with.\hello-cdk.go:32:8: undefined: jsiibefore the fix, succeeds afterward.All Submissions: