fix(apigateway): cannot create an ApiKey with an imported RestApi #22368
+526
−160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
ApiKey
is a little confusing. It takes aresources
property which expects a list ofIRestApi
s. An ApiKey is not associated with a RestApi by itself though, it needs to be associated with a specificStage
on the RestApi. When you import a RestApi you cannot import it with aStage
and even if you could provide anIStage
I don't think that makes the most sense (you can have multiple stages).Instead, this PR deprecates the
resources
prop and adds a newstages
prop which expects a list ofIStage
s. To facilitate this I have also done a couple of other thingsStage.fromStageAttributes()
.addApiKey
method toIStage
.fixes #22102
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integ
to deploy the infrastructure and generate the snapshot (i.e.yarn integ
without--dry-run
)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license