feat(sns): topic name with .fifo suffix generated automatically

[dreamorosi]

This PR adds logic for automatic generation of FIFO topics.

When customers don't pass a topicName during creation, the construct now generates an unique name that respects the maximum length allowed by the CloudFormation resource (256) and that ends with the .fifo suffix.

The previous behavior was to throw an error when the topic was of type FIFO and no name was passed.

Fixes ##18740

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

• This PR adds new unconventional dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

[dreamorosi]

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.

PRs must pass status checks before we can provide a meaningful review.

In this specific case the PR addresses an implementation detail inside the construct which in turns compensates a roadmap item from CloudFormation.

I'm not sure it needs a README change, if it does I'd appreciate some guidance as for where/what to change.

[corymhall]

I'm not sure it needs a README change, if it does I'd appreciate some guidance as for where/what to change.

Can you update the section of the readme that talks about fifo topics? Update the example to not pass a name and note that one will be generated for you.

aws-cdk/packages/@aws-cdk/aws-sns/README.md

Lines 22 to 33 in 635129c

	Add a FIFO SNS topic with content-based de-duplication to your stack:
	```ts
	const topic = new sns.Topic(this, 'Topic', {
	contentBasedDeduplication: true,
	displayName: 'Customer subscription topic',
	fifo: true,
	topicName: 'customerTopic',
	});
	```
	Note that FIFO topics require a topic name to be provided. The required `.fifo` suffix will be automatically added to the topic name if it is not explicitly provided.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[dreamorosi]

Can you update the section of the readme that talks about fifo topics? Update the example to not pass a name and note that one will be generated for you.

Done in the latest commit

[corymhall]

Thanks @dreamorosi!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 81b0eb4
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).