fix: CDK does not work in FIPS-restricted environments #22878
Merged
+287
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
added
the
pr-linter/exempt-integ-test
|
|
In an environment where node is compiled with FIPS restrictions in mind,
`crypto.createHash('md5')` does not work, for fear of MD5 being used for
crypto purposes.
We do not use it for crypto purposes, just to come up with unique
identifiers for certain constructs. Nevertheless, CDK cannot work if
`md5` is not available from the Node standard library.
Fall back to a pure JavaScript implementation if the built-in MD5 hash
does not work. This results in about a ~10x performance penalty, but the
only thing we can do in order to produce the same templates.
rix0rrr
force-pushed
the
huijbers/fips
branch
from
48efa8b to
a101cba
Compare
RomainMuller
approved these changes
Nov 15, 2022
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an environment where node is compiled with FIPS restrictions in mind,
crypto.createHash('md5')does not work, for fear of MD5 being used for crypto purposes.We do not use it for crypto purposes, just to come up with unique identifiers for certain constructs. Nevertheless, CDK cannot work if
md5is not available from the Node standard library.Fall back to a pure JavaScript implementation if the built-in MD5 hash
does not work. This results in about a ~10x performance penalty, but the
only thing we can do in order to produce the same templates.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license