Skip to content

feat(cfnspec): cloudformation spec v100.0.0 #23241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Dec 6, 2022

No description provided.

@aws-cdk-automation aws-cdk-automation added auto-approve pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Dec 6, 2022
@gitpod-io
Copy link

gitpod-io bot commented Dec 6, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team December 6, 2022 09:07
@github-actions github-actions bot added the p2 label Dec 6, 2022
@Naumel
Copy link
Contributor

Naumel commented Dec 7, 2022

@aws-cdk/aws-lambda: FAIL test/function-hash.test.js (6.532 s)
@aws-cdk/aws-lambda:   � function hash › corrected function hash › all CFN properties are classified
@aws-cdk/aws-lambda:     expect(received).toEqual(expected) // deep equality
@aws-cdk/aws-lambda:     - Expected  - 1
@aws-cdk/aws-lambda:     + Received  + 0
@aws-cdk/aws-lambda:     @@ -15,11 +15,10 @@
@aws-cdk/aws-lambda:         "MemorySize",
@aws-cdk/aws-lambda:         "PackageType",
@aws-cdk/aws-lambda:         "ReservedConcurrentExecutions",
@aws-cdk/aws-lambda:         "Role",
@aws-cdk/aws-lambda:         "Runtime",
@aws-cdk/aws-lambda:     -   "SnapStart",
@aws-cdk/aws-lambda:         "Tags",
@aws-cdk/aws-lambda:         "Timeout",
@aws-cdk/aws-lambda:         "TracingConfig",
@aws-cdk/aws-lambda:         "VpcConfig",
@aws-cdk/aws-lambda:       ]
@aws-cdk/aws-lambda:       411 |       const expected = Object.keys(spec.Properties!).sort();
@aws-cdk/aws-lambda:       412 |       const actual = Object.keys(VERSION_LOCKED).sort();
@aws-cdk/aws-lambda:     > 413 |       expect(actual).toEqual(expected);
@aws-cdk/aws-lambda:           |                      ^
@aws-cdk/aws-lambda:       414 |     });
@aws-cdk/aws-lambda:       415 |   });
@aws-cdk/aws-lambda:       416 | });
@aws-cdk/aws-lambda:       at Object.<anonymous> (test/function-hash.test.ts:413:22)

@mergify
Copy link
Contributor

mergify bot commented Dec 7, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9ac32c1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 084b037 into v1-main Dec 7, 2022
@mergify mergify bot deleted the bump-cfnspec-v1-main/v100.0.0 branch December 7, 2022 15:55
@mergify
Copy link
Contributor

mergify bot commented Dec 7, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-approve p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants