Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloud9): support setting automaticStopTimeMinutes #25593

Merged
merged 12 commits into from
Jun 5, 2023
Merged

feat(cloud9): support setting automaticStopTimeMinutes #25593

merged 12 commits into from
Jun 5, 2023

Conversation

ba032759
Copy link
Contributor

Add parameter automaticStopTimeMinutes to specify the number of minutes until the running instance is shut down after the environment was last used.

Closes #25592.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 15, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team May 15, 2023 11:15
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels May 15, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review May 26, 2023 10:00

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 26, 2023
corymhall
corymhall previously requested changes May 26, 2023
View reviewed changes
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 1 comment.

packages/@aws-cdk/aws-cloud9-alpha/lib/environment.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed corymhall’s stale review May 28, 2023 18:18

Pull request has been modified.

@ba032759 ba032759 requested a review from corymhall May 29, 2023 09:58
corymhall
corymhall previously requested changes Jun 1, 2023
View reviewed changes
packages/@aws-cdk/aws-cloud9-alpha/README.md Outdated Show resolved Hide resolved
@mergify mergify bot dismissed corymhall’s stale review June 1, 2023 14:15

Pull request has been modified.

@ba032759 ba032759 requested a review from corymhall June 1, 2023 18:09
corymhall
corymhall previously approved these changes Jun 5, 2023
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ba032759
Copy link
Contributor Author

ba032759 commented Jun 5, 2023

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2023

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission>=write

@mergify mergify bot dismissed corymhall’s stale review June 5, 2023 12:10

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 45edf63
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 437345e into aws:main Jun 5, 2023
7 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corymhall corymhall corymhall approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@aws-cdk/aws-cloud9-alpha: support automaticStopTimeMinutes in Cloud9 Ec2Environment
3 participants
@ba032759 @aws-cdk-automation @corymhall