Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kms): aliasName references alias itself (under feature flag) #25822

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Jun 1, 2023

Fixes #25761

The existing behavior was that alias.aliasName was always a raw string, so properties like keyId and keyArn depended on a raw string and not a reference to the alias itself. This behavior is preserved.

Under a new feature flag, const KMS_ALIAS_NAME_REF = '@aws-cdk/aws-kms:aliasNameRef', we instead use a reference to the aliasName output itself, which means that properties that depend on aliasName now depend on the alias. In turn, the alias depends on the key. This allows the expected behavior where specifying something like alias.keyArn() depends on the key.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 1, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 1, 2023 20:23
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Jun 1, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 1, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@kaizencc kaizencc added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jun 1, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 1, 2023 20:29

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2058fae
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 45734e3 into main Jun 2, 2023
7 checks passed
@mergify mergify bot deleted the conroy/aliasname branch June 2, 2023 10:28
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ottokruse
Copy link

This change breaks my existing code, because of the Ref I now get a CloudFormation circular dependency. I want the raw string, not the Ref. Is there a way to get the raw string?

@ottokruse
Copy link

This is because I want to use the name of the alias in a condition statement of my key policy

@ottokruse
Copy link

ottokruse commented Jun 12, 2023

FYI doing this to get the raw string again:

(key.node.defaultChild as cdk.aws_kms.CfnAlias).aliasName

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(s3): dependency not added when key alias provided as encryptionKey to bucket
4 participants