Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-scheduler-targets-alpha): Add SageMakerStartPipelineExecution Target #27457

Closed
1 of 2 tasks
filletofish opened this issue Oct 9, 2023 · 2 comments · Fixed by #28927
Closed
1 of 2 tasks

(aws-scheduler-targets-alpha): Add SageMakerStartPipelineExecution Target #27457

filletofish opened this issue Oct 9, 2023 · 2 comments · Fixed by #28927
Labels
@aws-cdk/aws-sagemaker Related to AWS SageMaker effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@filletofish
Copy link
Contributor

filletofish commented Oct 9, 2023

Describe the feature

Work to support L2 constructs for AWS Scheduler is in progress (#23394). See the approved RFC. RFC planned to add 12 templates targets, but only Lambda Invoke is currently implemented (#26575).

This issue tracks implementation of SageMakerStartPipelineExecution target to start Amazon SageMaker pipeline.

Use Case

Customers would like to use templated target SageMakerStartPipelineExecution to be able to start an Amazon SageMaker pipeline on schedule. L2 target construct should grant required permissions to the AWS Scheduler to start an Amazon SageMaker pipeline.

Proposed Solution

The proposed solution needs to be adopted to the recent examples of LambdaInvoke (https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-scheduler-targets-alpha/lib/lambda-invoke.ts).

Solution should also include unit and integration tests.

Class SageMakerStartPipelineExecution should:

  1. Grant Scheduler Execution Role permissions to start SageMaker pipeline via addTargetActionToRole
  2. Override bindBaseTargetConfig to return sageMakerPipelineParameters as part of ScheduleTargetConfig.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.99.1

Environment details (OS name and version, etc.)

MacOS

@filletofish filletofish added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 9, 2023
@github-actions github-actions bot added the @aws-cdk/aws-sagemaker Related to AWS SageMaker label Oct 9, 2023
@pahud
Copy link
Contributor

pahud commented Oct 9, 2023

Thank you for all those feature requests and PRs!

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 9, 2023
@mergify mergify bot closed this as completed in #28927 Feb 13, 2024
mergify bot pushed a commit that referenced this issue Feb 13, 2024
…et (#28927)

This PR adds SageMakerStartPipelineExecution Target for EventBridge Scheduler.

Closes #27457

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

GavinZZ pushed a commit that referenced this issue Feb 22, 2024
…et (#28927)

This PR adds SageMakerStartPipelineExecution Target for EventBridge Scheduler.

Closes #27457

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-sagemaker Related to AWS SageMaker effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants