Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(route53): delete old NS records on cross-account delegation renaming (#21249) #27523

Merged
merged 3 commits into from
Dec 6, 2023
Merged

fix(route53): delete old NS records on cross-account delegation renaming (#21249) #27523

merged 3 commits into from
Dec 6, 2023

Conversation

garciparedes
Copy link
Contributor

@garciparedes garciparedes commented Oct 12, 2023 •
edited

…ing (#21249)

Improve the CustomResource implementation that manages the Route53's NS Records on the Account that host the parent HostedZone to consider renaming cases in which updates and deletes are both required.

Closes #21249.

This is related to #25285

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Oct 12, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 12, 2023 17:56
@garciparedes garciparedes mentioned this pull request Oct 12, 2023
Closed
@garciparedes garciparedes force-pushed the fix-cross-account-zone-delegation branch 2 times, most recently from a3f9fe3 to 1847f06 Compare October 12, 2023 18:32
@garciparedes garciparedes force-pushed the fix-cross-account-zone-delegation branch from 1847f06 to 3f21dc3 Compare October 12, 2023 19:11
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@garciparedes garciparedes force-pushed the fix-cross-account-zone-delegation branch from 3f21dc3 to f3095e5 Compare October 12, 2023 19:41
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 12, 2023 19:43

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 12, 2023
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Dec 5, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 5, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5b0a7be
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 448e2bd into aws:main Dec 6, 2023
10 checks passed
sumupitchayan pushed a commit that referenced this pull request Dec 6, 2023
@garciparedes @sumupitchayan
fix(route53): delete old NS records on cross-account delegation renam…
8c38a3a 
…ing (#21249) (#27523)

…ing (#21249)

Improve the `CustomResource` implementation that manages the `Route53`'s `NS` Records on the Account that host the parent `HostedZone` to consider renaming cases in which updates and deletes are both required.

Closes #21249.

This is related to #25285

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@sumupitchayan sumupitchayan mentioned this pull request Dec 11, 2023
Closed
@garciparedes garciparedes deleted the fix-cross-account-zone-delegation branch December 19, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comcalvi comcalvi comcalvi approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(route53): CrossAccountZoneDelegationRecord does not remove old NS records when the zoneName changes
5 participants
@garciparedes @aws-cdk-automation @comcalvi @vinayak-kukreja @sumupitchayan