Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(EKS): (missed AMI type BOTTLEROCKET_x86_64_NVIDIA) #28241

Closed
hossein-zamanian opened this issue Dec 3, 2023 · 2 comments · Fixed by #28287
Closed

(EKS): (missed AMI type BOTTLEROCKET_x86_64_NVIDIA) #28241

hossein-zamanian opened this issue Dec 3, 2023 · 2 comments · Fixed by #28287
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@hossein-zamanian
Copy link

hossein-zamanian commented Dec 3, 2023

Describe the bug

BOTTLEROCKET_x86_64_NVIDIA is not included in the AMI type of EKS node groups.

Expected Behavior

Create a node group for the G4DN.Xlarge instance type using the BOTTLEROCKET_x86_64_NVIDIA AMI.

Current Behavior

Deployment failed with this error

The AMI type for your node group. GPU instance types should use the AL2_x86_64_GPU AMI type, which uses the Amazon EKS-optimized Linux AMI with GPU support. Non-GPU instances should use the AL2_x86_64 AMI type, which uses the Amazon EKS-optimized Linux AMI.

Reproduction Steps

        this.cluster.addNodegroupCapacity(this.id + "-GPUNodeGroup", {
            nodegroupName: this.id + "-GPUNodeGroup",
            labels: this.context.cluster.gpuNodeGroupLabels,
            desiredSize: 1,
            maxSize: 3,
            diskSize: 70,
            instanceTypes: [InstanceType.of(InstanceClass.G4DN, InstanceSize.XLARGE)],
            amiType: NodegroupAmiType.BOTTLEROCKET_x86_64_NVIDIA,
            subnets: {
                subnetType: SubnetType.PUBLIC,
                availabilityZones: [this.vpcStack.availabilityZones[0]],
            },
        });

Possible Solution

potential Solution d38677a
image

Additional Information/Context

The Amazon Linux GPU Nvidia driver version is 470, so I had to switch to BOTTLEROCKET_x86_64_NVIDIA in order to use a specific feature of the Nvidia driver that is only available in newer versions. However, when this was added to our CDK code, I encountered this issue.

CDK CLI Version

2.94.0 (build 987c329)

Framework Version

No response

Node.js Version

20.10.0

OS

Ubuntu

Language

TypeScript

Language Version

No response

Other information

No response

@hossein-zamanian hossein-zamanian added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 3, 2023
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Dec 3, 2023
@khushail
Copy link
Contributor

khushail commented Dec 4, 2023

Thanks for reporting this @hossein-zamanian . Since this is missing, I am converting this to feature request and if you are willing to work on it, please feel free to submit a PR. However community contributions are also welcome.

@khushail khushail added p2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. and removed needs-triage This issue or PR still needs to be triaged. bug This issue is a bug. labels Dec 4, 2023
mergify bot added a commit to lpizzinidev/aws-cdk that referenced this issue Dec 8, 2023
@mergify mergify bot closed this as completed in #28287 Dec 8, 2023
mergify bot pushed a commit that referenced this issue Dec 8, 2023
Adds support for `BOTTLEROCKET_ARM_64_NVIDIA` and `BOTTLEROCKET_x86_64_NVIDIA` AMI types.

Closes #28241.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

github-actions bot commented Dec 8, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants