Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(codepipeline): feature flag update to crossAccountKeys #28247

Closed
2 tasks
kaizencc opened this issue Dec 4, 2023 · 1 comment · Fixed by #28556
Closed
2 tasks

(codepipeline): feature flag update to crossAccountKeys #28247

kaizencc opened this issue Dec 4, 2023 · 1 comment · Fixed by #28556
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@kaizencc
Copy link
Contributor

kaizencc commented Dec 4, 2023

Describe the feature

aws-cdk/packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts

Lines 380 to 381 in f4c1d12

// @deprecated(v2): switch to default false
this.crossAccountKeys = props.crossAccountKeys ?? true;

In documentation, we mention updating the default for CDK v2. We did not do that. It's not great to blindly update the defaults anyway, but sounds like we should add it in with feature flag.

Use Case

Update default

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

cdk v2.100.0

Environment details (OS name and version, etc.)

mac
@kaizencc kaizencc added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 4, 2023
@github-actions github-actions bot added the @aws-cdk/aws-codepipeline Related to AWS CodePipeline label Dec 4, 2023
@pahud pahud added p1 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Dec 5, 2023
@github-actions github-actions bot mentioned this issue Jan 1, 2024
Closed
@go-to-k go-to-k mentioned this issue Jan 3, 2024
Merged
@mergify mergify bot closed this as completed in #28556 Feb 2, 2024
mergify bot pushed a commit that referenced this issue Feb 2, 2024
@go-to-k
feat(codepipeline): change default value for crossAccountKeys to fals…
144b1b9 
…e (under feature flag) (#28556)

[The documentation](https://github.com/aws/aws-cdk/blob/f4c1d1253ee34c2837a57a93faa47c9da97ef6d8/packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts#L380-L381) mentions updating the default for CDK v2. Sounds like we should add it in with feature flag.

Closes #28247.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

SankyRed pushed a commit that referenced this issue Feb 8, 2024
@go-to-k @SankyRed
feat(codepipeline): change default value for crossAccountKeys to fals…
356648d 
…e (under feature flag) (#28556)

[The documentation](https://github.com/aws/aws-cdk/blob/f4c1d1253ee34c2837a57a93faa47c9da97ef6d8/packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts#L380-L381) mentions updating the default for CDK v2. Sounds like we should add it in with feature flag.

Closes #28247.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TheRealAmazonKendra pushed a commit that referenced this issue Feb 9, 2024
@go-to-k @TheRealAmazonKendra
feat(codepipeline): change default value for crossAccountKeys to fals…
4c3b931 
…e (under feature flag) (#28556)

[The documentation](https://github.com/aws/aws-cdk/blob/f4c1d1253ee34c2837a57a93faa47c9da97ef6d8/packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts#L380-L381) mentions updating the default for CDK v2. Sounds like we should add it in with feature flag.

Closes #28247.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
2 participants
@pahud @kaizencc