Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): add NAT instance V2 support using AL2023 #29013

Merged
merged 6 commits into from Mar 4, 2024
Merged

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Feb 7, 2024

Issue # (if applicable)

Closes #28907

Reason for this change

Current NAT instance image has reached EOL on Dec 31 2023.

Description of changes

If NAT instances are a better match for your use case than NAT gateways, you can create your own NAT AMI from a current version of Amazon Linux as described in Create a NAT AMI.

Description of how you validated changes

New unit and integration tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 7, 2024 13:59
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Feb 7, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 7, 2024
aws-cdk-automation

This comment was marked as resolved.

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 7, 2024 14:47

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@GavinZZ GavinZZ marked this pull request as ready for review February 7, 2024 15:12
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 7, 2024
@GavinZZ GavinZZ changed the title feat(ec2): add NAT instance V2 support using AL2 feat(ec2): add NAT instance V2 support using AL2023 Feb 8, 2024
packages/aws-cdk-lib/aws-ec2/README.md Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 9, 2024
@GavinZZ GavinZZ requested a review from kaizencc February 9, 2024 03:18
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments @GavinZZ.

packages/aws-cdk-lib/aws-ec2/lib/nat.ts Show resolved Hide resolved
packages/aws-cdk-lib/aws-ec2/lib/nat.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ec2/lib/nat.ts Show resolved Hide resolved
@GavinZZ
Copy link
Contributor Author

GavinZZ commented Feb 29, 2024

@kaizencc Can I get another review? I would love to have this PR merged.

Copy link
Contributor

mergify bot commented Mar 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 40f5c13
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7fa6bbf into main Mar 4, 2024
12 checks passed
@mergify mergify bot deleted the yuanhaoz/nat_v2 branch March 4, 2024 18:29
Copy link
Contributor

mergify bot commented Mar 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ec2: Upgrade NatInstanceProvider
4 participants