feat: allow overriding the filename of the processed file after substitution #29029
+34,643
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
effort/medium
aws-cdk-automation
previously requested changes
Feb 8, 2024
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
jmgtan
changed the title
destinationKey property to DeployTimeSubstitutedFile constructdestinationKey property to DeployTimeSubstitutedFile construct
jmgtan
changed the title
destinationKey property to DeployTimeSubstitutedFile constructdestinationKey property to DeployTimeSubstitutedFile construct
jmgtan
changed the title
destinationKey property to DeployTimeSubstitutedFile constructdestinationKey property to DeployTimeSubstitutedFile construct
jmgtan
changed the title
destinationKey property to DeployTimeSubstitutedFile constructdestinationKey property to DeployTimeSubstitutedFile
jmgtan
changed the title
destinationKey property to DeployTimeSubstitutedFileDeployTimeSubstitutedFile
jmgtan
changed the title
DeployTimeSubstitutedFile
jmgtan
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
jmgtan
force-pushed
the
feat/deploy-time-sub-destkey
branch
from
c96fa6f to
ee5a554
Compare
jmgtan
changed the title
aws-cdk-automation
previously requested changes
Feb 11, 2024
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
removed
the
pr/needs-community-review
jmgtan
changed the title
…construct. This allows users optionally indicate the resulting object key the processed file would be uploaded into.
jmgtan
force-pushed
the
feat/deploy-time-sub-destkey
branch
from
b9044c2 to
ae877ce
Compare
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
GavinZZ
approved these changes
Feb 11, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
GavinZZ
pushed a commit
that referenced
this pull request
Feb 22, 2024
…itution (#29029) ### Issue # (if applicable) Closes #28450 ### Reason for this change Currently, the filename is automatically generated based on its fingerprint. There's no way to override the resulting filename. ### Description of changes Added an optional `destinationKey` parameter. If this is provided, the construct would use the `destinationKey` when uploading the resulting processed file to S3. If the `destinationKey` is not provided, the current approach would be the default. ### Description of how you validated changes Added a unit test to confirm that the correct filename is being used. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #28450
Reason for this change
Currently, the filename is automatically generated based on its fingerprint. There's no way to override the resulting filename.
Description of changes
Added an optional
destinationKeyparameter. If this is provided, the construct would use thedestinationKeywhen uploading the resulting processed file to S3. If thedestinationKeyis not provided, the current approach would be the default.Description of how you validated changes
Added a unit test to confirm that the correct filename is being used.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license