feat(cloudwatch): add TableWidget
#29078
Conversation
github-actions
bot
added
admired-contributor
|
I've asked the cloudwatch team to provide updates to https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/CloudWatch-Dashboard-Body-Structure.html to reflect the new table widget support. I went ahead with this implementation based on
And right after sending this PR, I got access to an internal draft doc update. PR Reviewer, plz let me know if you'd like access to that doc. |
humanzz
changed the title
TableWidget
aws-cdk-automation
added
the
pr/needs-community-review
| export interface TableSummaryProps { | ||
| /** | ||
| * Summary columns | ||
| * @see TableSummary |
| * Thresholds for highlighting cells in TableWidget | ||
| */ | ||
| export class TableThreshold { | ||
|
|
| private readonly props: TableWidgetProps; | ||
|
|
||
| private readonly metrics: IMetric[]; | ||
|
|
||
| constructor(props: TableWidgetProps) { |
There was a problem hiding this comment.
| private readonly props: TableWidgetProps; | |
| private readonly metrics: IMetric[]; | |
| constructor(props: TableWidgetProps) { | |
| private readonly metrics: IMetric[]; | |
| constructor(private readonly props: TableWidgetProps) { |
There was a problem hiding this comment.
Did you fully deploy this integ test and confirm in the console that the dashboard looks as expected?
There was a problem hiding this comment.
I've only generated the snapshots, but haven't really looked in console.
let me do that as part of addressing the other comments
There was a problem hiding this comment.
Here are a couple of screenshots for the dashboard/metrics deployed
There was a problem hiding this comment.
I assume that is what you expected!
There was a problem hiding this comment.
Yes... given that it's not a real existing metric
aws-cdk-automation
removed
the
pr/needs-community-review
mergify
bot
dismissed
kaizencc’s stale review
Pull request has been modified.
aws-cdk-automation
added
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
### Issue # (if applicable) closes #28975. ### Reason for this change add support for table widget https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/add_remove_table_dashboard.html ### Description of changes add a new `TableWidget` and its supporting property classes/interfaces ### Description of how you validated changes added both unit/integ tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Issue # (if applicable)
closes #28975.
Reason for this change
add support for table widget https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/add_remove_table_dashboard.html
Description of changes
add a new
TableWidgetand its supporting property classes/interfacesDescription of how you validated changes
added both unit/integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license