Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): proxy for mariadb #29412

Merged
merged 5 commits into from Mar 14, 2024
Merged

feat(rds): proxy for mariadb #29412

merged 5 commits into from Mar 14, 2024

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Mar 8, 2024

MariaDB is grouped with MySQL, hence adding MYSQL as the engine family for MariaDB.

Screenshot 2024-03-08 at 12 02 36 PM

Closes #29402.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 8, 2024 18:04
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Mar 8, 2024
@msambol msambol changed the title 29402v2 feat(rds): enable proxy for mariadb Mar 8, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 8, 2024
@msambol msambol changed the title feat(rds): enable proxy for mariadb feat(rds): proxy for mariadb Mar 8, 2024
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Just a suggestion on the documentation.

packages/aws-cdk-lib/aws-rds/README.md Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 9, 2024
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Copy link
Contributor

mergify bot commented Mar 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 12, 2024
Copy link
Contributor

mergify bot commented Mar 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@msambol
Copy link
Contributor Author

msambol commented Mar 12, 2024

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Mar 12, 2024

refresh

✅ Pull request refreshed

@msambol
Copy link
Contributor Author

msambol commented Mar 13, 2024

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Mar 13, 2024

refresh

✅ Pull request refreshed

@msambol
Copy link
Contributor Author

msambol commented Mar 13, 2024

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Mar 13, 2024

refresh

✅ Pull request refreshed

@msambol
Copy link
Contributor Author

msambol commented Mar 14, 2024

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Mar 14, 2024

refresh

✅ Pull request refreshed

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2eb0e07
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6fef789 into aws:main Mar 14, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Mar 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rds: Add support for MariaDB RDS Proxy
4 participants