Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cognito): Add idpInitiated flag to UserPoolIdentityProviderSaml #29598

Closed
1 of 2 tasks
Booligoosh opened this issue Mar 25, 2024 · 7 comments · Fixed by #29588
Closed
1 of 2 tasks

(cognito): Add idpInitiated flag to UserPoolIdentityProviderSaml #29598

Booligoosh opened this issue Mar 25, 2024 · 7 comments · Fixed by #29588
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@Booligoosh
Copy link
Contributor

Booligoosh commented Mar 25, 2024

Describe the feature

Cognito now supports IdP-initiated SAML auth flows, however it requires an option being set on the User Pool Identity Provider: https://docs.aws.amazon.com/cognito/latest/developerguide/cognito-user-pools-SAML-session-initiation.html

The option is available in the AWS console under the "IDP-initiated SAML sign-in" section when editing a SAML identity provider, just under the "Sign-out flow" section.

Use Case

I can't currently enable IdP-initiated auth without using a CFN override:

const cfnSamlProvider = samlProvider.node.defaultChild as cognito.CfnUserPoolIdentityProvider;
cfnSamlProvider.providerDetails.IDPInit = "true";

Proposed Solution

Add a new prop idpInitiated: boolean to UserPoolIdentityProviderSaml that controls whether ProviderDetails.IDPInit is set to "true" or "false".

Other Information

Related to PR #29588 and issue #29494

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.115.0

Environment details (OS name and version, etc.)

Windows 10 Enterprise

@Booligoosh Booligoosh added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 25, 2024
@github-actions github-actions bot added the @aws-cdk/aws-cognito Related to Amazon Cognito label Mar 25, 2024
@msambol
Copy link
Contributor

msambol commented Mar 25, 2024

@badmintoncryer Do you want to take this and add it to #29588 ?

@badmintoncryer
Copy link
Contributor

badmintoncryer commented Mar 25, 2024

@msambol Of course! I can take it.

@Booligoosh If you prefer to create the PR yourself, that's fine too. Which do you want to?

@Booligoosh
Copy link
Contributor Author

Hi @badmintoncryer, if you're happy to take it, that'd be awesome, cheers!! If you don't want to though, I can do it.

@badmintoncryer
Copy link
Contributor

@Booligoosh Sure! I'll take it😃

@tim-finnigan tim-finnigan self-assigned this Mar 25, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 25, 2024
@tim-finnigan
Copy link

Thank you for the feature request and the PR!

@tim-finnigan tim-finnigan added p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Mar 25, 2024
@tim-finnigan tim-finnigan removed their assignment Mar 25, 2024
@mergify mergify bot closed this as completed in #29588 Apr 17, 2024
@mergify mergify bot closed this as completed in 375f1a6 Apr 17, 2024
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

1 similar comment
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants