Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sns: Support for TracingConfig #29714

Closed
1 of 2 tasks
jun1-t opened this issue Apr 4, 2024 · 3 comments · Fixed by #29783 · May be fixed by NOUIY/aws-solutions-constructs#98 or NOUIY/aws-solutions-constructs#99
Closed
1 of 2 tasks

sns: Support for TracingConfig #29714

jun1-t opened this issue Apr 4, 2024 · 3 comments · Fixed by #29783 · May be fixed by NOUIY/aws-solutions-constructs#98 or NOUIY/aws-solutions-constructs#99
Labels
@aws-cdk/aws-sns Related to Amazon Simple Notification Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@jun1-t
Copy link
Contributor

jun1-t commented Apr 4, 2024

Describe the feature

Enable setting of TracingConfig in the L2 construct for SNS topics.
https://docs.aws.amazon.com/sns/latest/dg/sns-active-tracing.html###

Use Case

Currently, to set the TracingConfig, it is necessary to configure it via L1.
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_sns.CfnTopic.html#tracingconfig

Proposed Solution

Allows passing the "TracingConfig" parameter as an argument.

const topic = new sns.Topic(this, 'MyTopic', {
  tracingConfig: 'Active',
});

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.135.0

Environment details (OS name and version, etc.)

irrelevant

@jun1-t jun1-t added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 4, 2024
@github-actions github-actions bot added the @aws-cdk/aws-sns Related to Amazon Simple Notification Service label Apr 4, 2024
@khushail
Copy link
Contributor

khushail commented Apr 4, 2024

Thanks @jun1-t for reaching out and submitting a PR for the same.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 4, 2024
@mergify mergify bot closed this as completed in #29783 Apr 12, 2024
@mergify mergify bot closed this as completed in f14b60f Apr 12, 2024
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

1 similar comment
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-sns Related to Amazon Simple Notification Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
2 participants