Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-appsync): Add Enhanced Metrics configuration to CDK #29933

Open
1 of 2 tasks
piotrmoszkowicz opened this issue Apr 23, 2024 · 3 comments · May be fixed by #29940
Open
1 of 2 tasks

(aws-appsync): Add Enhanced Metrics configuration to CDK #29933

piotrmoszkowicz opened this issue Apr 23, 2024 · 3 comments · May be fixed by #29940
Labels
@aws-cdk/aws-appsync Related to AWS AppSync effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@piotrmoszkowicz
Copy link
Contributor

Describe the feature

AWS AppSync some time ago introduced enhanced monitoring (https://docs.aws.amazon.com/appsync/latest/devguide/monitoring.html -> Enhanced Metrics), which allows to collect metrics at resolver/operation/data source leve. It is added within the CloudFormation (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-appsync-graphqlapi.html -> EnhancedMetricsConfig), so I think it would be great feature within CDK. I will be happy to implement it, maybe even within end of the week ;)

Use Case

Ability to configure AWS AppSync with Enhanced Monitoring.

Proposed Solution

Add missing property to AppSync's L2 construct and map it properly to AWS CloudFormation.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.138.0

Environment details (OS name and version, etc.)

MacOS Ventura
@piotrmoszkowicz piotrmoszkowicz added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 23, 2024
@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Apr 23, 2024
@khushail
Copy link
Contributor

Hi @piotrmoszkowicz , thanks for requesting this feature and agreeing to volunteer for L2 contruct PR. It would be a helpful feature and there is already needed support by cloudformation. So please go ahead and feel free to submit the PR.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 23, 2024
@piotrmoszkowicz piotrmoszkowicz linked a pull request Apr 23, 2024 that will close this issue
Open
1 task
@piotrmoszkowicz
Copy link
Contributor Author

Hi @khushail, done! Please take a look and help with review ;)

@khushail
Copy link
Contributor

Appreciate your efforts @piotrmoszkowicz . Team would be reviewing it.

This was referenced Apr 26, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-appsync Related to AWS AppSync effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(appsync): add Enhanced Monitoring piotrmoszkowicz/aws-cdk
2 participants
@piotrmoszkowicz @khushail