Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-eks: addAutoScalingGroupCapacity lacks support for Amazon Linux 2023 #29983

Open
2 tasks
isker opened this issue Apr 26, 2024 · 4 comments
Open
2 tasks

aws-eks: addAutoScalingGroupCapacity lacks support for Amazon Linux 2023 #29983

isker opened this issue Apr 26, 2024 · 4 comments
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@isker
Copy link
Contributor

isker commented Apr 26, 2024

Describe the feature

addAutoScalingGroupCapacity allows the user to select a MachineImageType, but this only includes AL2 or Bottlerocket. AL2023 is missing.

https://github.com/aws/aws-cdk/blob/v2.139.0/packages/aws-cdk-lib/aws-eks/lib/cluster.ts#L2468-L2480

Use Case

I want to use a newer kernel than is available in AL2 on my EKS ASGs.

Proposed Solution

No response

Other Information

AL2023 support has been added for managed node groups but not for ASGs. See #29546 #29334. cc @pahud as you've handled those issues.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.139.0

Environment details (OS name and version, etc.)

N/A

@isker isker added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 26, 2024
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Apr 26, 2024
@pahud
Copy link
Contributor

pahud commented Apr 29, 2024

Yes we could have a PR for that. But I am wondering why you opt in addAutoScalingGroupCapacity rather than addNodeGroupCapacity? Is there any feature not supported in the managed nodegroups?

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 29, 2024
@isker
Copy link
Contributor Author

isker commented Apr 29, 2024

@pahud
Copy link
Contributor

pahud commented May 1, 2024

@isker Is it because Nodegroup currently does not support tagging ASG? This would be a huge tradeoff. In CDK, you still can create a managed nodegroup and a custom resource to tag the ASG behind the nodegroup. Would this be something you expect?

check #29280 (comment) and #29280 (comment)

Feel free to chat with me on cdk.dev if you need.

@pahud pahud added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label May 1, 2024
@isker
Copy link
Contributor Author

isker commented May 1, 2024

Thanks for that information. I'll take a look.

CDK should support AL2023 on EKS ASGs.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants