Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all process.chdir calls in all tests #7775

Closed
rix0rrr opened this issue May 4, 2020 · 1 comment
Closed

Remove all process.chdir calls in all tests #7775

rix0rrr opened this issue May 4, 2020 · 1 comment
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. management/devenv Related to CDK development/build environment ops-excellence Operational Excellence p2 testing Related to tests needed to be modified or added.

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented May 4, 2020

A Jest engineer told me that changing directory in a test is not allowed, and may break assumptions Jest makes about the structure of tests.

We should rewrite our code to make sure we don't chdir in tests.

When this is done, we can get rid of the dependency on graceful-fs which was added to the root at a particular version to ensure that we deduplicate the right instances of graceful-fs (in order to not get hit by a caching bug).

Source:
jestjs/jest#9923 (comment)

Where we added the dependency to force deduplication to work around a multiple-instance-issue with graceful-fs:
#7667
@rix0rrr rix0rrr added ops-excellence Operational Excellence management/devenv Related to CDK development/build environment needs-triage This issue or PR still needs to be triaged. no-autoclose labels May 4, 2020
@SomayaB SomayaB added testing Related to tests needed to be modified or added. and removed needs-triage This issue or PR still needs to be triaged. labels May 5, 2020
@SomayaB SomayaB added the feature-request A feature should be added or improved. label Jun 22, 2020
@rix0rrr rix0rrr added p2 effort/large Large work item – several weeks of effort labels Aug 12, 2020
@rix0rrr rix0rrr removed their assignment Jun 3, 2021
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 3, 2022
@github-actions github-actions bot closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. management/devenv Related to CDK development/build environment ops-excellence Operational Excellence p2 testing Related to tests needed to be modified or added.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rix0rrr @SomayaB