Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codebuild): project didn't have permissions to retrieve secret of image with credentials #8845

Merged
merged 3 commits into from Jul 2, 2020

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented Jul 1, 2020

For build images that used credentials,
the role of the project wasn't granted permissions to read the secret from SecretsManager,
which meant the build would always fail executing in the 'Provisioning' phase.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

… image with credentials

For build images that used credentials,
the role of the project wasn't granted permissions to read the secret from SecretsManager,
which meant the build would always fail executing in the 'Provisioning' phase.
@skinny85 skinny85 requested review from iliapolo and NetaNir July 1, 2020 20:02
@skinny85 skinny85 self-assigned this Jul 1, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 1, 2020
@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 0a392d2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4326f24 into aws:master Jul 2, 2020
@skinny85 skinny85 deleted the fix/codebuild-image-secret-permissions branch July 2, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants