Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apigateway] does not detect addPropertyOverride changes for deployment hash #9086

Closed
mhart opened this issue Jul 15, 2020 · 1 comment
Closed
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort p2

Comments

@mhart
Copy link

mhart commented Jul 15, 2020

Using addPropertyOverride on API properties, such as auth, fails to result in new API Gateway Deployments – likely due to these changes not being picked up by the hashing mechanism.

Reproduction Steps

  1. Deploy a stack with a LambdaRestApi with deploy set to true (the default)
  2. Modify an API method using addPropertyOverride – for example in the manner suggested here: defaultMethodOptions should be selectively applied to CORS OPTIONS method #8615 (comment)
  3. Update the stack
  4. Observe that a new Deployment has not been created – so the changes to the API remain undeployed.

Other

If this is deemed out of scope for addPropertyOverride modifications (which may make sense if they're too hard to use in the hashing mechanism), then at least the documentation should be updated to mention that you may need to manually take action for scenarios like auto-deployments.

Also when addPropertyOverride is mentioned as a potential solution to a problem in the issue tracker / forum, it would be good to add this caveat (and any other apis that may be affected by using addPropertyOverride).


This is 🐛 Bug Report

@mhart mhart added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 15, 2020
@github-actions github-actions bot added the @aws-cdk/aws-apigateway Related to Amazon API Gateway label Jul 15, 2020
@nija-at nija-at added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jul 16, 2020
@nija-at nija-at added the effort/small Small work item – less than a day of effort label Aug 10, 2020
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

No branches or pull requests

2 participants